Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dts: entropy: cleanup Kconfig and replace CONFIG_ENTROPY_NAME with DT_ENTROPY_NAME #24127

Merged
merged 4 commits into from
Apr 13, 2020
Merged

dts: entropy: cleanup Kconfig and replace CONFIG_ENTROPY_NAME with DT_ENTROPY_NAME #24127

merged 4 commits into from
Apr 13, 2020

Conversation

galak
Copy link
Collaborator

@galak galak commented Apr 6, 2020

No description provided.

carlescufi
carlescufi approved these changes Apr 6, 2020
View reviewed changes
Copy link
Member

@carlescufi carlescufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zephyrbot zephyrbot added area: Devicetree area: Boards area: native port Host native arch port (native_sim) area: Networking area: Bluetooth area: Samples Samples area: Tests Issues related to a particular existing or missing test labels Apr 6, 2020
@galak galak requested a review from dbkinder as a code owner April 9, 2020 09:07
@galak galak marked this pull request as draft April 9, 2020 09:07
@galak galak added the dev-review To be discussed in dev-review meeting label Apr 9, 2020
@zephyrbot zephyrbot added area: API Changes to public APIs area: Documentation labels Apr 9, 2020
@zephyrbot
Copy link
Collaborator

zephyrbot commented Apr 9, 2020 •
edited
Loading

All checks are passing now.

checkpatch (informational only, not a failure)

-:729: WARNING:LONG_LINE: line over 80 characters
#729: FILE: kernel/init.c:391:
+	struct device *entropy = device_get_binding(DT_CHOSEN_ZEPHYR_ENTROPY_LABEL);

- total: 0 errors, 1 warnings, 765 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: AVOID_EXTERNS BRACES CONFIG_EXPERIMENTAL CONST_STRUCT DATE_TIME FILE_PATH_CHANGES MINMAX NETWORKING_BLOCK_COMMENT_STYLE PRINTK_WITHOUT_KERN_LEVEL SPLIT_STRING VOLATILE

NOTE: If any of the errors are false positives, please report
      them to the maintainers.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

pabigot
pabigot reviewed Apr 9, 2020
View reviewed changes
Copy link
Collaborator

@pabigot pabigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to make some sense, in spite of it possibly starting a slide down a slope to a massive chosen section.

doc/zephyr.doxyfile.in Show resolved Hide resolved
@mbolivar-nordic mbolivar-nordic mentioned this pull request Apr 9, 2020
Closed
@galak galak force-pushed the dt-entropy-name branch from ecfab98 to 22f16be Compare April 9, 2020 16:32
@galak galak marked this pull request as ready for review April 9, 2020 16:33
@galak galak requested review from ioannisg, MaureenHelm, pabigot, cvinayak and mbolivar-nordic and removed request for cvinayak April 9, 2020 16:33
@galak
Copy link
Collaborator Author

galak commented Apr 9, 2020

Reworked this PR based on discussion in dev-review. Pulled in some commits from @mbolivar-nordic PR on FLASH. This now uses a chosen property to specify the entropy device.

@dbkinder dbkinder removed their request for review April 9, 2020 21:23
galak and others added 4 commits April 13, 2020 07:38
@galak
devicetree.h: Move device includes to the end
cf65217 
Move the include of files from include/devicetree/*.h to the end so that
when those files are processes they have access to all previous defined
macros.

Signed-off-by: Kumar Gala <[email protected]>
@mbolivar-nordic @galak
include: devicetree.h: API for /chosen zephyr,foo
474a499 
Add a devicetree/zephyr.h header, which is meant to contain
definitions for /chosen properties specific to Zephyr.

Currently, this just deals with zephyr,entropy.  We add a
DT_CHOSEN_ZEPHYR_ENTROPY_LABEL macro which expands to the label for the
node pointed to by zephyr,entropy.

Signed-off-by: Martí Bolívar <[email protected]>
Signed-off-by: Kumar Gala <[email protected]>
@galak
drivers: entropy: replace CONFIG_ENTROPY_NAME with DT macro
8e49040 
Replace CONFIG_ENTROPY_NAME with DT_CHOSEN_ZEPHYR_ENTROPY_LABEL.  We now
set zephyr,entropy in the chosen node of the device tree to the entropy
device.

This allows us to remove CONFIG_ENTROPY_NAME from dts_fixup.h.  Also
remove any other stale ENTROPY related defines in dts_fixup.h files.

Signed-off-by: Kumar Gala <[email protected]>
@galak
drivers: entropy: Remove Kconfig HAS_DTS_ENTROPY
ba72348 
Now that all entropy drivers use DTS we can remove HAS_DTS_ENTROPY being
set everywhere as well as Kconfig ENTROPY_NAME since that is now coming
from DT_ENTROPY_NAME.

Signed-off-by: Kumar Gala <[email protected]>
@galak galak force-pushed the dt-entropy-name branch from 22f16be to ba72348 Compare April 13, 2020 12:38
@galak galak merged commit 8b6930e into zephyrproject-rtos:master Apr 13, 2020
@galak galak deleted the dt-entropy-name branch April 13, 2020 14:14
@nandojve nandojve mentioned this pull request Apr 18, 2020
Closed
61 tasks
@pabigot pabigot removed the dev-review To be discussed in dev-review meeting label May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbolivar-nordic mbolivar-nordic mbolivar-nordic approved these changes

@dcpleung dcpleung dcpleung approved these changes

@erwango erwango erwango approved these changes

@carlescufi carlescufi carlescufi approved these changes

@cvinayak cvinayak cvinayak approved these changes

@pabigot pabigot pabigot approved these changes

@andrewboie andrewboie Awaiting requested review from andrewboie

@jukkar jukkar Awaiting requested review from jukkar

@nandojve nandojve Awaiting requested review from nandojve

@nashif nashif Awaiting requested review from nashif

@tbursztyka tbursztyka Awaiting requested review from tbursztyka

@anangl anangl Awaiting requested review from anangl

@kgugala kgugala Awaiting requested review from kgugala

@nategraff-sifive nategraff-sifive Awaiting requested review from nategraff-sifive

@pgielda pgielda Awaiting requested review from pgielda

@benpicco benpicco Awaiting requested review from benpicco

@ioannisg ioannisg Awaiting requested review from ioannisg

@MaureenHelm MaureenHelm Awaiting requested review from MaureenHelm

Assignees
No one assigned
Labels
area: API Changes to public APIs area: Bluetooth area: Boards area: Devicetree area: Documentation area: Kernel area: native port Host native arch port (native_sim) area: Networking area: Samples Samples area: Tests Issues related to a particular existing or missing test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.