Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: atmel sam0: Convert atmel sam0 drivers to new DT_INST macros #23739

Merged
merged 2 commits into from
Mar 27, 2020

Conversation

galak
Copy link
Collaborator

@galak galak commented Mar 24, 2020

Convert older DT_INST_ macro use in atmel sam0 drivers to the new
include/devicetree.h DT_INST macro APIs.

Signed-off-by: Kumar Gala [email protected]

@zephyrbot
Copy link
Collaborator

zephyrbot commented Mar 24, 2020

All checks passed.

checkpatch (informational only, not a failure)

-:110: WARNING:LONG_LINE: line over 80 characters
#110: FILE: drivers/gpio/gpio_sam0.c:309:
+		.port_pin_mask = GPIO_PORT_PIN_MASK_FROM_NGPIOS(DT_INST_PROP(0, ngpios)),

-:119: WARNING:LONG_LINE: line over 80 characters
#119: FILE: drivers/gpio/gpio_sam0.c:330:
+		.port_pin_mask = GPIO_PORT_PIN_MASK_FROM_NGPIOS(DT_INST_PROP(1, ngpios)),

-:128: WARNING:LONG_LINE: line over 80 characters
#128: FILE: drivers/gpio/gpio_sam0.c:351:
+		.port_pin_mask = GPIO_PORT_PIN_MASK_FROM_NGPIOS(DT_INST_PROP(2, ngpios)),

-:137: WARNING:LONG_LINE: line over 80 characters
#137: FILE: drivers/gpio/gpio_sam0.c:372:
+		.port_pin_mask = GPIO_PORT_PIN_MASK_FROM_NGPIOS(DT_INST_PROP(3, ngpios)),

-:390: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8)
#390: FILE: drivers/usb/device/usb_dc_sam0.c:184:
 	do {							\
+	IRQ_CONNECT(DT_INST_IRQ_BY_IDX(0, n, irq),		\

- total: 0 errors, 5 warnings, 461 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: AVOID_EXTERNS BRACES CONFIG_EXPERIMENTAL CONST_STRUCT DATE_TIME FILE_PATH_CHANGES MINMAX NETWORKING_BLOCK_COMMENT_STYLE PRINTK_WITHOUT_KERN_LEVEL SPLIT_STRING VOLATILE

NOTE: If any of the errors are false positives, please report
      them to the maintainers.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

galak added 2 commits March 26, 2020 17:45
Convert older DT_INST_ macro use in atmel sam0 drivers to the new
include/devicetree.h DT_INST macro APIs.

Signed-off-by: Kumar Gala <[email protected]>
Convert older DT_INST_ macro use the new include/devicetree.h
DT_INST macro APIs.

Signed-off-by: Kumar Gala <[email protected]>
@galak galak force-pushed the dt-new-inst-sam0 branch from 11f13f0 to 2ab4ccf Compare March 26, 2020 22:45
Copy link
Member

@ioannisg ioannisg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for the .fixup file changes

Copy link
Collaborator

@nvlsianpu nvlsianpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for the flash driver.

@MaureenHelm MaureenHelm merged commit 3300751 into zephyrproject-rtos:master Mar 27, 2020
@galak galak deleted the dt-new-inst-sam0 branch March 30, 2020 20:00
@galak galak restored the dt-new-inst-sam0 branch March 30, 2020 20:01
@galak galak deleted the dt-new-inst-sam0 branch March 30, 2020 20:02
@nandojve nandojve mentioned this pull request Apr 4, 2020
61 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: I2C area: Timer Timer area: Watchdog Watchdog platform: Microchip SAM Microchip SAM Platform (formerly Atmel SAM)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants