Bluetooth: Document bt_conn_unref in public API and fix missing unref in samples #23066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Document the need for the caller to call bt_conn_unref on the connection object returned from API functions. Signed-off-by: Joakim Andersson <[email protected]>
Move the connected callback down together with the disconnected callback. Signed-off-by: Joakim Andersson <[email protected]>
Handle connected callback with error status not releasing the default conn object in central samples. This can happen when the initiator fails to create the connection within 3 seconds and is canceled by the host. Also restart the scan role in this case. Signed-off-by: Joakim Andersson <[email protected]>
zephyrbot
added
area: Bluetooth
area: API
jhedberg
approved these changes
Feb 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document the need for the caller to call bt_conn_unref on the
connection object returned from API functions.
Based on feedback here: #23050 (comment)
Fix missing unref in connected callback in the central samples. This error happens when initiator is canceled by the host through a timeout.