kernel: remove problematic pend() assertion #23000
Conversation
This assertion, if built in, allows users threads to crash the kernel in a critical section by passing a negative timeout value, creating a DoS attack vector. Remove this assertion, immediately below it there's a check which just resets it to 0 anyway. Fixes: zephyrproject-rtos#22999 Signed-off-by: Andrew Boie <[email protected]>
andrewboie
requested review from
nashif,
andyross,
ceolin,
ioannisg,
nordic-krch and
dcpleung
andrewboie
added
bug
|
note that there is a kind of precedence in this case. If user provides invalid value (api states that it must be non-negative of K_FORVER) then value is fixed. It was added only temporarily, together with the assert to detect misuse. Temporarily because timers rework was about to progress (and it does not so far) and switch to unsigned values in near future. I know it's release time but if unsigned timeouts are not coming shortly then maybe it should return |
We're at release time, and the code already clamps non K_FOREVER timeout values at 0 and above anyway. |
This assertion, if built in, allows users threads to crash
the kernel in a critical section by passing a negative timeout
value, creating a DoS attack vector.
Remove this assertion, immediately below it there's a check
which just resets it to 0 anyway.
Fixes: #22999
Signed-off-by: Andrew Boie [email protected]