Fix multiple Kconfig warnings when building samples/hello_world #22831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Override the default log buffer size only when logging is actually enabled. See zephyrproject-rtos#22474. Signed-off-by: Carles Cufi <[email protected]>
For the non-secure image, the architecture still supports secure execution, so express that in the defconfig. See zephyrproject-rtos#22474. Signed-off-by: Carles Cufi <[email protected]>
Enable RNG only if the actual entropy generator is enabled. See zephyrproject-rtos#22474. Signed-off-by: Carles Cufi <[email protected]>
In order to overrdie a choice one needs to define it again. Override it by redefining it in the .defconfig file. See zephyrproject-rtos#22474. Signed-off-by: Carles Cufi <[email protected]>
Set the ztest stack size only when ztest itself is enabled. See zephyrproject-rtos#22474. Signed-off-by: Carles Cufi <[email protected]>
Enable RNG only if the actual entropy generator is enabled. See zephyrproject-rtos#22474. Signed-off-by: Carles Cufi <[email protected]>
This board now has an entropy driver, no need to use the test one anymore. See zephyrproject-rtos#22474. Signed-off-by: Carles Cufi <[email protected]>
This board now has an entropy driver, no need to use the test one anymore. See zephyrproject-rtos#22474. Signed-off-by: Carles Cufi <[email protected]>
carlescufi
requested review from
anangl,
dcpleung,
fallrisk,
fvincenzo,
galak,
ioannisg,
MaureenHelm,
nashif,
ruuddw,
vonhust and
ydamigos
as code owners
erwango
approved these changes
Feb 14, 2020
|
All checks are passing now. Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages. |
MaureenHelm
approved these changes
Feb 14, 2020
Override the default log buffer size only when logging is actually enabled. See zephyrproject-rtos#22474. Signed-off-by: Carles Cufi <[email protected]>
Set the IPM console stack size only when the console is enabled. See zephyrproject-rtos#22474. Signed-off-by: Carles Cufi <[email protected]>
In the default configuration we want to enable the generic GPIO module so that we avoid Kconfig warnings. See zephyrproject-rtos#22474. Signed-off-by: Carles Cufi <[email protected]>
Set the IPM console stack size only when the console is enabled. See zephyrproject-rtos#22474. Signed-off-by: Carles Cufi <[email protected]>
Fix up the board definition so that the actual board can at least be processed by Kconfig. See zephyrproject-rtos#22474. Signed-off-by: Carles Cufi <[email protected]>
carlescufi
force-pushed
the
kconfig-warnings
branch
from
2f7ddb4
to
35e7d3e
Compare
dcpleung
approved these changes
Feb 14, 2020
ydamigos
approved these changes
Feb 14, 2020
pabigot
approved these changes
Feb 14, 2020
jhedberg
approved these changes
Feb 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages.
Fixes #22474.