Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

canopen: CO_driver: Fix Coverity issues (NULL deref, dead code) #22456

Merged
merged 1 commit into from
Feb 6, 2020
Merged

canopen: CO_driver: Fix Coverity issues (NULL deref, dead code) #22456

merged 1 commit into from
Feb 6, 2020

Conversation

alexanderwachter
Copy link
Member

@alexanderwachter alexanderwachter commented Feb 4, 2020 •
edited
Loading

This PR fixes Coverity issue 207978, 207977 and 207964.
There were two dereference after NULL check and logical dead code.

#22434, #22435, #22443

@alexanderwachter alexanderwachter added Coverity A Coverity detected issue or its fix area: CAN labels Feb 4, 2020
@alexanderwachter alexanderwachter added this to the v2.2.0 milestone Feb 4, 2020
henrikbrixandersen
henrikbrixandersen approved these changes Feb 4, 2020
View reviewed changes
Copy link
Member

@henrikbrixandersen henrikbrixandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was looking into those as well, but you beat me to it. Thank you.

jukkar
jukkar reviewed Feb 4, 2020
View reviewed changes
Copy link
Member

@jukkar jukkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add to commit log body this info

Fixes #22434 
Fixes #22443 
Fixes #22435 
Coverity-CID: 207978
Coverity-CID: 207977
Coverity-CID: 207964

@alexanderwachter
Copy link
Member Author

@jukkar Done.

@alexanderwachter
canopen: CO_driver: Fix Coverity issues (NULL deref, dead code)
07097f0 
There were two dereference after NULL check and logical dead code.

Fixes zephyrproject-rtos#22434
Fixes zephyrproject-rtos#22443
Fixes zephyrproject-rtos#22435
Coverity-CID: 207978
Coverity-CID: 207977
Coverity-CID: 207964

Signed-off-by: Alexander Wachter <[email protected]>
@jukkar jukkar merged commit fd9733e into zephyrproject-rtos:master Feb 6, 2020
@alexanderwachter alexanderwachter deleted the canopen_coverity_fix branch January 30, 2021 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jukkar jukkar jukkar approved these changes

@henrikbrixandersen henrikbrixandersen henrikbrixandersen approved these changes

@nashif nashif Awaiting requested review from nashif

@carlescufi carlescufi Awaiting requested review from carlescufi

Assignees
No one assigned
Labels
area: CAN Coverity A Coverity detected issue or its fix
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@alexanderwachter @henrikbrixandersen @jukkar