tests: drivers: counter: counter_basic_api: Fix single_shot_alarm #22305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test_single_shot_alarm_instance may fail due to not supported setting of top_value in call to counter_set_top_value. Modified to accept not supported case. Fixes zephyrproject-rtos#21745 Signed-off-by: Erwan Gouriou <[email protected]>
erwango
added
area: Counter
area: Tests
carlescufi
approved these changes
Jan 29, 2020
nashif
approved these changes
Jan 29, 2020
nordic-krch
approved these changes
Jan 29, 2020
|
The original ticket seems already closed; do we need this PR finally? |
|
@ioannisg ticket was actually showing 2 errors in the test. I fixed one, this is set second one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_single_shot_alarm_instance may fail due to not supported setting
of top_value in call to counter_set_top_value.
Modified to accept not supported case.
Fixes #21745
Signed-off-by: Erwan Gouriou [email protected]