Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers/flash: fix warnings about missing casts in flash includes #21291

Closed
wants to merge 1 commit into from

Conversation

szundi
Copy link

@szundi szundi commented Dec 11, 2019

fix warnings about missing casts in /include/drivers/flash.h on the dev->driver_api

Fixes #21290

fix warnings about missing casts in /include/drivers/flash.h on the dev->driver_api
@zephyrbot zephyrbot added the area: API Changes to public APIs label Dec 11, 2019
@zephyrbot
Copy link
Collaborator

Some checks failed. Please fix and resubmit.

Identity/Emails issues

b5031bd: author email (András Szabó [email protected]) needs to match one of the signed-off-by entries.

checkpatch issues

-:10: WARNING:LONG_LINE: line over 80 characters
#10: FILE: include/drivers/flash.h:104:
+	const struct flash_driver_api *api = (const struct flash_driver_api*)dev->driver_api;

-:10: ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#10: FILE: include/drivers/flash.h:104:
+	const struct flash_driver_api *api = (const struct flash_driver_api*)dev->driver_api;

-:19: WARNING:LONG_LINE: line over 80 characters
#19: FILE: include/drivers/flash.h:128:
+	const struct flash_driver_api *api = (const struct flash_driver_api*)dev->driver_api;

-:19: ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#19: FILE: include/drivers/flash.h:128:
+	const struct flash_driver_api *api = (const struct flash_driver_api*)dev->driver_api;

-:28: WARNING:LONG_LINE: line over 80 characters
#28: FILE: include/drivers/flash.h:159:
+	const struct flash_driver_api *api = (const struct flash_driver_api*)dev->driver_api;

-:28: ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#28: FILE: include/drivers/flash.h:159:
+	const struct flash_driver_api *api = (const struct flash_driver_api*)dev->driver_api;

-:37: WARNING:LONG_LINE: line over 80 characters
#37: FILE: include/drivers/flash.h:185:
+	const struct flash_driver_api *api = (const struct flash_driver_api*)dev->driver_api;

-:37: ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#37: FILE: include/drivers/flash.h:185:
+	const struct flash_driver_api *api = (const struct flash_driver_api*)dev->driver_api;

-:46: WARNING:LONG_LINE: line over 80 characters
#46: FILE: include/drivers/flash.h:272:
+	const struct flash_driver_api *api = (const struct flash_driver_api*)dev->driver_api;

-:46: ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#46: FILE: include/drivers/flash.h:272:
+	const struct flash_driver_api *api = (const struct flash_driver_api*)dev->driver_api;

- total: 5 errors, 5 warnings, 40 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: AVOID_EXTERNS BRACES CONFIG_EXPERIMENTAL CONST_STRUCT DATE_TIME FILE_PATH_CHANGES MINMAX NETWORKING_BLOCK_COMMENT_STYLE PRINTK_WITHOUT_KERN_LEVEL SPLIT_STRING VOLATILE

NOTE: If any of the errors are false positives, please report
      them to the maintainers.

Gitlint issues

1: UC2 Body does not contain a 'Signed-off-by:' line
3: UC4 Line exceeds max length (83>72): "fix warnings about missing casts in /include/drivers/flash.h on the dev->driver_api"

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

Copy link
Collaborator

@nvlsianpu nvlsianpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix all CI issues.
Technically the patch looks good

@nvlsianpu nvlsianpu added area: Flash Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. labels Dec 11, 2019
@nvlsianpu
Copy link
Collaborator

nvlsianpu commented Dec 11, 2019

commit message should looks like:

drivers/flash: fix warnings about missing casts

fix warnings about missing casts in /include/drivers/flash.h on the dev->driver_api

fixes #21290

Signed-off-by: András Szabó <[email protected]>

@nvlsianpu nvlsianpu changed the title drivers: fix warnings about missing casts in flash includes drivers/flash: fix warnings about missing casts in flash includes Dec 11, 2019
Copy link
Collaborator

@nvlsianpu nvlsianpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI issues need to be fixed

@carlescufi
Copy link
Member

@szundi please add a Signed-off-by line as documented here: https://docs.zephyrproject.org/latest/contribute/index.html#pull-requests-and-issues and fix the current CI issues.

@szundi
Copy link
Author

szundi commented Dec 12, 2019

resubmitting

@szundi szundi closed this Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: API Changes to public APIs area: Flash Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiler warnings in flash.h: invalid conversion from 'const void*' to 'const flash_driver_api*'
4 participants