drivers: usb_dc_nrfx: free memory block if event is intended to be dropped #21244
Conversation
jfischer-no
added
bug
drivers/usb/device/usb_dc_nrfx.c
Outdated
| @@ -451,8 +451,12 @@ static inline struct usbd_event *usbd_evt_alloc(void) | |||
|
|
|||
| if (ret < 0) { | |||
| LOG_ERR("USBD event allocation failed!"); | |||
| if (k_is_in_isr()) { | |||
There was a problem hiding this comment.
Could You please provide an explanation for this?
There was a problem hiding this comment.
It can not be flushed in ISR (in the issue it is usb_dc_nrfx_power_event_callback()). "The kernel does allow an ISR to remove an item from a fifo" from https://docs.zephyrproject.org/latest/reference/kernel/data_passing/fifos.html Oh forget it.
There was a problem hiding this comment.
I misunderstood something. But flushing did not work here.
Free memory block if event is intended to be dropped. Resolves: zephyrproject-rtos#20953 Signed-off-by: Johann Fischer <[email protected]>
Remove not relevant bashing comments. Signed-off-by: Johann Fischer <[email protected]>
jfischer-no
force-pushed
the
pr-fix-pwr_event-usb_dc_nrfx
branch
from
48e068d
to
8781d78
Compare
No, the driver has a issue, it does not free the memory block. This patch fixes this issue, it is not a workaround!!! |
Do not try to flush event queue in ISR.
Free memory block if event is intended to be dropped.
Resolves: #20953