arch: arm: Inline arch_isr_direct_header. #20446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit inlines arch_isr_direct_header function that was previously placed in irq_manage.c for no good reason (possibly in relation to the FIXME for zephyrproject-rtos#3056). In addition, since the PR zephyrproject-rtos#20119 resolved the header circular dependency issue described in the issue zephyrproject-rtos#3056, this commit removes the references to it in the code. The reason for not inlining _arch_is_direct_pm as the zephyrproject-rtos#3056 FIXME suggests is that there is little to gain from doing so and there still exists circular dependency for the headers required by this function (zephyrproject-rtos#20119 only addresses kernel_structs.h, which is required for _current and _kernel, which, in turn, is required for handling interrupt nesting in many architectures; in fact, Cortex-A and Cortex-R port will require it as well). Signed-off-by: Stephanos Ioannidis <[email protected]>
stephanosio
requested review from
andrewboie,
galak,
ioannisg and
MaureenHelm
as code owners
zephyrbot
added
area: ARM
andrewboie
approved these changes
Nov 8, 2019
11 tasks
ioannisg
reviewed
Nov 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit inlines arch_isr_direct_header function that was previously
placed in irq_manage.c for no good reason (possibly in relation to the
FIXME for #3056).
In addition, since the PR #20119 resolved the header circular
dependency issue described in the issue #3056, this commit removes the
references to it in the code.
The reason for not inlining _arch_is_direct_pm as the #3056 FIXME
suggests is that there is little to gain from doing so and there still
exists circular dependency for the headers required by this function
(#20119 only addresses kernel_structs.h, which is required for _current
and _kernel, which, in turn, is required for handling interrupt nesting
in many architectures; in fact, Cortex-A and Cortex-R port will require
it as well).
Signed-off-by: Stephanos Ioannidis [email protected]