[TOPIC-GPIO] drivers: gpio_mchp_xec: update to use new GPIO API #19555
Conversation
dcpleung
requested review from
albertofloyd,
franciscomunoz and
scottwcpg
as code owners
galak
changed the title
drivers/gpio/gpio_mchp_xec.c
Outdated
| u32_t gpio_interrupt = 0; | ||
| u32_t pcr1 = 0U; | ||
| u32_t mask = 0U; | ||
| __IO u32_t *gpio_base = (__IO u32_t *)(GPIO_PAROUT_BASE |
There was a problem hiding this comment.
HAL has MCHP_GPIO_PAROUT_ADDR(n) where n is the port number 0 <= port num < NUM_MCHP_GPIO_PORTS
There was a problem hiding this comment.
MCHP_GPIO_BASE_ADDR is not defined so those macros cannot be used.
Yes, the test passed. I also tried manually with the sample |
This adds an overlay file for board mec15xxevb_assy6853 for the gpio_basic_api test. Signed-off-by: Daniel Leung <[email protected]>
This adds LEDs into the DTS file so various GPIO tests can utilize this definitions. Signed-off-by: Daniel Leung <[email protected]>
zephyrbot
added
area: Boards
area: Tests
|
Rebased to latest |
Update driver code and board files to use new GPIO configuration flags such as GPIO_ACTIVE_LOW. Also add implementation of new port_* driver API as well as gpio_pin_interrupt_configure function. Signed-off-by: Daniel Leung <[email protected]>
There was a problem hiding this comment.
The code looks good. Since the driver supports simultaneous input/output configuration could you also run the tests/drivers/gpio/gpio_api_1pin test? All the test_gpio_port_* test cases are unfortunately going to fail on your board (I'm working on the fix), please ignore. The remaining should pass.
I ran it too and it passed. |
Update driver code and board files to use new GPIO configuration flags
such as GPIO_ACTIVE_LOW. Also add implementation of new port_* driver
API as well as gpio_pin_interrupt_configure function.
Signed-off-by: Daniel Leung [email protected]