drivers: gpio: Make PCA9535 driver generic to support multiple PCA95xx devices #19262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All checks are passing now. Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages. |
albertofloyd
force-pushed
the
pca95xx
branch
2 times, most recently
from
fd5e8b1
to
8812245
Compare
|
@albertofloyd we need to move this driver to the new GPIO API, see #18530 same for the XEC gpio driver (gpio_mchp_xec.c) |
albertofloyd
force-pushed
the
pca95xx
branch
from
8812245
to
3582940
Compare
|
@nashif can this additional KConfig been included in the porting process for this driver? @franciscomunoz can you take a look into changes needed for gpio_xec? |
…evices Make original driver generic to support also PCA9555 device PCA9535 and PCA9555 share most of functionality and registers PCA9555 doesn't have programmable pull-up/down for the pins A new KConfig option will allow to disable this feature Signed-off-by: Jose Alberto Meza <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PCA9535 and PCA9555 IO-expanders share most of functionality and registers, the intention of this change is to make existing driver generic for both devices. The alternative will be to add a new PCA9555 driver with mostly same functionality that existing one.
PCA9535 delta features are: programmable output drive strength, latchable inputs,
pull-up/pull-down resistors, maskable interrupts and drain or push-pull outputs. From these current gpio driver only uses the support for pull-up/pull-down. The new KConfig GPIO_PCAL95XX_PUD allows to disable this feature when PC9555A is used.
Note: Original driver is not tracked in code owners hence adding owners based on git log history.
Signed-off-by: Jose Alberto Meza [email protected]