Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: Add "runsan" sanitycheck auxilliary runner #18656

Closed
wants to merge 1 commit into from

Conversation

andyross
Copy link
Contributor

This commit adds a proof of concept tool that runs qemu-based
sanitycheck output in a modified context where CPU load is firmly
constrained, so as to avoid qemu timing warps from host CPU load.

It's intended as a significant performance boost for "try these tests
on an unloaded system" workloads, which still exploits as much
parallelism as possible, keeps run logs in a saner way than "ninja
run", and produces easily interpreted log output on stdout. You can
put this script in a loop overnight and come back to tens of thousands
of individiual test run results.

Signed-off-by: Andy Ross [email protected]

This commit adds a proof of concept tool that runs qemu-based
sanitycheck output in a modified context where CPU load is firmly
constrained, so as to avoid qemu timing warps from host CPU load.

It's intended as a significant performance boost for "try these tests
on an unloaded system" workloads, which still exploits as much
parallelism as possible, keeps run logs in a saner way than "ninja
run", and produces easily interpreted log output on stdout.  You can
put this script in a loop overnight and come back to tens of thousands
of individiual test run results.

Signed-off-by: Andy Ross <[email protected]>
@andyross andyross added the DNM This PR should not be merged (Do Not Merge) label Aug 26, 2019
@andyross
Copy link
Contributor Author

Throwing this up so I can reference the tool in replies about spurious failures. This is what I'm using to isolate "presumptive host timer interaction" from "apparently real bugs"

@zephyrbot
Copy link
Collaborator

Found the following issues, please fix and resubmit:

checkpatch issues

-:106: ERROR:TRAILING_WHITESPACE: trailing whitespace
#106: FILE: scripts/runsan/patch.diff:29:
+ $

-:120: ERROR:TRAILING_WHITESPACE: trailing whitespace
#120: FILE: scripts/runsan/patch.diff:43:
+ $

-:126: ERROR:TRAILING_WHITESPACE: trailing whitespace
#126: FILE: scripts/runsan/patch.diff:49:
+ $

-:128: ERROR:TRAILING_WHITESPACE: trailing whitespace
#128: FILE: scripts/runsan/patch.diff:51:
++        $

-:245: ERROR:TRAILING_WHITESPACE: trailing whitespace
#245: FILE: scripts/runsan/runsan.pl:108:
+    $

-:266: WARNING:TYPO_SPELLING: 'becuase' may be misspelled - perhaps 'because'?
#266: FILE: scripts/runsan/runsan.pl:129:
+	# -monitor, becuase I still see stuff on the console that

- total: 5 errors, 1 warnings, 317 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

NOTE: Whitespace errors detected.
      You may wish to use scripts/cleanpatch or scripts/cleanfile

Your patch has style problems, please review.

NOTE: Ignored message types: AVOID_EXTERNS BRACES CONFIG_EXPERIMENTAL CONST_STRUCT DATE_TIME FILE_PATH_CHANGES MINMAX NETWORKING_BLOCK_COMMENT_STYLE PRINTK_WITHOUT_KERN_LEVEL SPLIT_STRING VOLATILE

NOTE: If any of the errors are false positives, please report
      them to the maintainers.



Codeowners issues

New files added that are not covered in CODEOWNERS:

scripts/runsan/README.txt
scripts/runsan/patch.diff
scripts/runsan/runsan.pl
scripts/runsan/setup-runsan.pl

Please add one or more entries in the CODEOWNERS file to cover those files


License issues

In most cases you do not need to do anything here, especially if the files
reported below are going into ext/ and if license was approved for inclusion
into ext/ already. Fix any missing license/copyright issues. The license
exception if a JFYI for the maintainers and can be overriden when merging the
pull request.

  • scripts/runsan/runsan.pl missing license.
  • scripts/runsan/runsan.pl missing copyright.
  • scripts/runsan/setup-runsan.pl missing license.
  • scripts/runsan/setup-runsan.pl missing copyright.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DNM This PR should not be merged (Do Not Merge) Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants