Decouple system timer and drivers: UART #15356
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pizi-nordic
requested review from
galak,
Mani-Sadhasivam,
MaureenHelm and
nashif
as code owners
pizi-nordic
force-pushed
the
decouple-system-timer-and-clock-uart
branch
from
e2d4f5b
to
b0038a3
Compare
ioannisg
approved these changes
Apr 17, 2019
pizi-nordic
force-pushed
the
decouple-system-timer-and-clock-uart
branch
from
b016e11
to
519a76d
Compare
pizi-nordic
force-pushed
the
decouple-system-timer-and-clock-uart
branch
from
519a76d
to
3265917
Compare
The uart_cmsdk_apb driver used system clock frequency as a base for baudrate calculation. This commit corrects that by obtaining the needed value from DTS. Signed-off-by: Piotr Zięcik <[email protected]>
The uart_pl011 driver used system clock frequency as a base for baudrate calculation. This commit corrects that by obtaining the needed value from DTS. Signed-off-by: Piotr Zięcik <[email protected]>
The uart_cc32xx driver used system clock frequency as a base for baudrate calculation. This commit corrects that by obtaining the needed value from DTS. Signed-off-by: Piotr Zięcik <[email protected]>
The uart_msp432p4xx driver used system clock frequency as a base for baudrate calculation. This commit corrects that by obtaining the needed value from DTS. Signed-off-by: Piotr Zięcik <[email protected]>
The uart_qmsi driver used system clock frequency as a base for baudrate calculation. This commit corrects that by obtaining the needed value from DTS. Signed-off-by: Piotr Zięcik <[email protected]>
The uart_stellaris driver used system clock frequency as a base for baudrate calculation. This commit corrects that by obtaining the needed value from DTS. Signed-off-by: Piotr Zięcik <[email protected]>
pizi-nordic
force-pushed
the
decouple-system-timer-and-clock-uart
branch
from
3265917
to
4d71c9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During our work in timer area, we found that system clock frequency is used incorrectly in several drivers.
For example, it is used to obtain bus frequency needed to calculate baud rate of the UART interfaces.
If we select different system timer device, all these calculations become invalid.
This PR fixes the problem by obtaining all needed information directly from the DTS.
Brings us closer to: #15363