Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: twister: hwmap: missing serial_pty definition #81380

Closed
hakehuang opened this issue Nov 14, 2024 · 2 comments
Closed

test: twister: hwmap: missing serial_pty definition #81380

hakehuang opened this issue Nov 14, 2024 · 2 comments
Assignees
Labels
area: Twister Twister bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug
Milestone

Comments

@hakehuang
Copy link
Collaborator

Describe the bug

the serial_pty definition is missing. in hardwaremap.py

Please also mention any information which could help others to understand
the problem you're facing:

  • What target platform are you using?
  • any
  • What have you tried to diagnose or workaround this issue?
  • No
  • Is this a regression? If yes, have you been able to "git bisect" it to a
    specific commit?
  • this seems missing cherry-pick 78f688a

To Reproduce

scripts/twister --device-testing --hardware-map map.yaml -T samples/

Expected behavior

Impact

Logs and console output

INFO    - Using Ninja..
INFO    - Zephyr version: v3.7.1-rc1
INFO    - Using 'zephyr' toolchain.
Traceback (most recent call last):
  File "/home/ubuntu/nxp/frdm_ke15z/zephyr/scripts/twister", line 215, in <module>
    ret = main(options, default_options)
  File "/home/ubuntu/nxp/frdm_ke15z/zephyr/scripts/pylib/twister/twisterlib/twister_main.py", line 115, in main
    ret = hwm.discover()
  File "/home/ubuntu/nxp/frdm_ke15z/zephyr/scripts/pylib/twister/twisterlib/hardwaremap.py", line 169, in discover
    self.load(self.options.hardware_map)
  File "/home/ubuntu/nxp/frdm_ke15z/zephyr/scripts/pylib/twister/twisterlib/hardwaremap.py", line 239, in load
    flash_before = self.options.flash_before and (not (flash_with_test or serial_pty))
UnboundLocalError: local variable 'serial_pty' referenced before assignment
Keeping artifacts untouched

Environment (please complete the following information):

  • OS: (e.g. Linux, MacOS, Windows)
  • Toolchain (e.g Zephyr SDK, ...)
  • Commit SHA or Version used: v3.7.1-rc1
@hakehuang hakehuang added bug The issue is a bug, or the PR is fixing a bug area: Twister Twister labels Nov 14, 2024
@hakehuang hakehuang added this to the v3.7.1 milestone Nov 14, 2024
@hakehuang
Copy link
Collaborator Author

@nashif please check this, cherry-pick the 78f688a will fix this, and then I can run a board testing for this release, Thanks

@nashif
Copy link
Member

nashif commented Nov 20, 2024

merged

@nashif nashif closed this as completed Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Twister Twister bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug
Projects
None yet
Development

No branches or pull requests

2 participants