Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved toolchain / libc handling #53856

Open
tejlmand opened this issue Jan 17, 2023 · 1 comment
Open

Improved toolchain / libc handling #53856

tejlmand opened this issue Jan 17, 2023 · 1 comment
Assignees
Labels
area: Build System Enhancement Changes/Updates/Additions to existing features

Comments

@tejlmand
Copy link
Collaborator

tejlmand commented Jan 17, 2023

Is your enhancement proposal related to a problem? Please describe.
PR #12393 introduced the TOOLCHAIN_HAS_NEWLIB CMake variable being used for twister filtering.
The PR #36140 introduced export of this symbol into Kconfig.

The issue should improve consistency in Zephyr toolchain handling by using actual TOOLCHAIN_HAS_<library> to ensure better dependency handling for toolchains as well as consistency in Zephyr build system configurations.

Describe the solution you'd like
The exported TOOLCHAIN_HAS_<lib> should be used by Kconfig:

TOOLCHAIN_HAS_NEWLIB=$<IF:$<BOOL:${TOOLCHAIN_HAS_NEWLIB}>,y,n>

Describe alternatives you've considered
In toolchain WG it has been discussed if it would be possible and feasible to extend toolchain testing from basic compile flag testing to feature based testing, such as linker flag testing or libc / newlib / picolibc testing.

Such toolchain can be seen as further improvement, as having a TOOLCHAIN_HAS_<lib> infrastructure in place in Kconfig doesn't impact how that information is obtained (by fixed CMake setting or obtained through toolchain testing).

Additional context

@tejlmand tejlmand added the Enhancement Changes/Updates/Additions to existing features label Jan 17, 2023
@tejlmand tejlmand self-assigned this Jan 17, 2023
@zephyrbot
Copy link
Collaborator

Hi @tejlmand,

This issue, marked as an Enhancement, was opened a while ago and did not get any traction. Please confirm the issue is correctly assigned and re-assign it otherwise.

Please take a moment to review if the issue is still relevant to the project. If it is, please provide feedback and direction on how to move forward. If it is not, has already been addressed, is a duplicate, or is no longer relevant, please close it with a short comment explaining the reason.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Build System Enhancement Changes/Updates/Additions to existing features
Projects
Status: To do
Development

No branches or pull requests

2 participants