LL_ASSERT in isr_radio_state_close()

[zephyrbot]

Reported by Johan Hedberg:

0x000008d0 in bt_controller_assert_handle (file=0xb165 "",
file@entry=0xb12c "/home/jh/src/zephyr/subsys/bluetooth/controller/ll/ctrl.c",
line=2333) at /home/jh/src/zephyr/samples/bluetooth/hci_uart/src/main.c:308
308 uart_poll_out(hci_uart_dev, line >> 24 & 0xff);
(gdb) bt
#0 0x000008d0 in bt_controller_assert_handle (file=0xb165 "",
file@entry=0xb12c "/home/jh/src/zephyr/subsys/bluetooth/controller/ll/ctrl.c",
line=2333) at /home/jh/src/zephyr/samples/bluetooth/hci_uart/src/main.c:308
#1 0x00007544 in isr_radio_state_close ()
at /home/jh/src/zephyr/subsys/bluetooth/controller/ll/ctrl.c:2684
#2 isr () at /home/jh/src/zephyr/subsys/bluetooth/controller/ll/ctrl.c:2759
#3 0x000019fc in isr_radio ()
at /home/jh/src/zephyr/subsys/bluetooth/controller/hal/nrf5/radio.c:29
#4 0x00008e92 in radio_nrf5_isr_body ()
at /home/jh/src/zephyr/subsys/bluetooth/controller/hci/hci_driver.c:155
#5 radio_nrf5_isr ()
at /home/jh/src/zephyr/subsys/bluetooth/controller/hci/hci_driver.c:153
#6
#7 0x0800dfea in ?? ()
#8 0xf7ff8002 in ?? ()
Backtrace stopped: previous frame identical to this frame (corrupt stack?)
(gdb) up
#1 0x00007544 in isr_radio_state_close ()
at /home/jh/src/zephyr/subsys/bluetooth/controller/ll/ctrl.c:2684
warning: Source file is more recent than executable.
2684 LL_ASSERT(0);
(gdb) p _radio.role
$1 = ROLE_ADV

HCI:

< HCI Command: LE Set Advertise Enable (0x08|0x000a) plen 1 10271.532834
Advertising: Disabled (0x00)

HCI Event: Vendor (0xff) plen 12 10271.533879
aa 63 74 72 6c 2e 63 00 1d 09 00 00 .ctrl.c.....

(Imported from Jira ZEP-1852)

[zephyrbot]

by Vinayak Kariappa Chettimada:

Cause:
If a role closes graceful while it is being stopped, then
radio ISR will be triggered to process the stop state with
no active role at that instance in time.

Fix:
Just reset the state to none. The role has gracefully
closed before this ISR execution. The above applies to
aborting a role event too.

[zephyrbot]

by Mark Linkmeyer:

Hi Johan Hedberg , can you please verify this bug is fixed? Sharron has marked it as requiring verification by the reporter, and that's you. :-)