Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gen_defines does not resolve symbol values for devicetree.conf #23415

Closed
stephanosio opened this issue Mar 12, 2020 · 1 comment · Fixed by #23427
Closed

gen_defines does not resolve symbol values for devicetree.conf #23415

stephanosio opened this issue Mar 12, 2020 · 1 comment · Fixed by #23427
Labels
area: Devicetree Tooling PR modifies or adds a Device Tree tooling bug The issue is a bug, or the PR is fixing a bug

Comments

@stephanosio
Copy link
Member

Describe the bug
scripts/dts/gen_defines.py does not resolve symbol values for devicetree.conf.

For instance, we have:

DT_INST_0_ATMEL_SAM_GMAC_QUEUE_NUM=DT_ATMEL_SAM_GMAC_40050088_QUEUE_NUM

when it should be:

DT_INST_0_ATMEL_SAM_GMAC_QUEUE_NUM=6

To Reproduce
Build any project and take a look at zephyr/include/generated/devicetree.conf.

Impact
Kconfig functions such as dt_int_val and dt_hex_val fail.

Additional context
86645aa is the offending commit.
@stephanosio stephanosio added bug The issue is a bug, or the PR is fixing a bug area: Devicetree Tooling PR modifies or adds a Device Tree tooling labels Mar 12, 2020
@stephanosio
Copy link
Member Author

cc @mbolivar @galak

@stephanosio stephanosio mentioned this issue Mar 12, 2020
Merged
@stephanosio stephanosio linked a pull request Mar 12, 2020 that will close this issue
Revert changes to scripts/dts/gen_defines.py as they break things #23427
Merged
@nandojve nandojve mentioned this issue Apr 18, 2020
Closed
61 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: Devicetree Tooling PR modifies or adds a Device Tree tooling bug The issue is a bug, or the PR is fixing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert changes to scripts/dts/gen_defines.py as they break things galak/zephyr
1 participant
@stephanosio