Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bluetooth: controller: ASSERTION FAIL on invalid packet sequence #22967

Closed
cvinayak opened this issue Feb 20, 2020 · 0 comments · Fixed by #22971 or #23547
Closed

Bluetooth: controller: ASSERTION FAIL on invalid packet sequence #22967

cvinayak opened this issue Feb 20, 2020 · 0 comments · Fixed by #22971 or #23547
Assignees
@cvinayak
Labels
area: Bluetooth bug The issue is a bug, or the PR is fixing a bug priority: high High impact/importance bug
Milestone
v2.2.0

Comments

@cvinayak
Copy link
Contributor

Describe the bug
A rough central device using invalid sequence number in the first connection event causes assertion failure in the controller.

To Reproduce
Steps to reproduce the behavior:

  1. mkdir build; cd build
  2. cmake -DBOARD=nrf52_pca10040 ../samples/bluetooth/peripheral
  3. make
  4. See error

Expected behavior
No assertion failure.

Impact
showstopper

Screenshots or console output

*** Booting Zephyr OS build v2.2.0-rc1-172-g7de708dcf068  ***
Bluetooth initialized
Advertising successfully started
[00:00:00.007,385] <inf> fs_nvs: 6 Sectors of 4096 bytes
[00:00:00.007,385] <inf> fs_nvs: alloc wra: 0, fa8
[00:00:00.007,415] <inf> fs_nvs: data wra: 0, e4
[00:00:00.008,880] <inf> bt_hci_core: HW Platform: Nordic Semiconductor (0x0002)
[00:00:00.008,880] <inf> bt_hci_core: HW Variant: nRF52x (0x0002)
[00:00:00.008,880] <inf> bt_hci_core: Firmware: Standard Bluetooth controller (0x00) Version 2.2 Build 0
[00:00:00.009,155] <inf> bt_hci_core: No ID address. App must call settings_load()
[00:00:00.011,932] <inf> bt_hci_core: Identity: c1:ab:66:13:11:2e (random)
[00:00:00.011,932] <inf> bt_hci_core: HCI: version 5.1 (0x0a) revision 0x0000, manufacturer 0x05f1
[00:00:00.011,932] <inf> bt_hci_core: LMP: version 5.1 (0x0a) subver 0xffff
Connected
ASSERTION FAIL [link] @ ZEPHYR_BASE/subsys/bluetooth/controller/ll_sw/nordic/lll/lll_conn.c:681
[00:00:19.360,534] <err> os: r0/a1:  0x00000003  r1/a2:  0x0000000a  r2/a3:  0x00000001
[00:00:19.360,534] <err> os: r3/a4:  0x0002083a r12/ip:  0xb9c18001 r14/lr:  0x00015627
[00:00:19.360,534] <err> os:  xpsr:  0x61000011
[00:00:19.360,534] <err> os: Faulting instruction address (r15/pc): 0x00015632
[00:00:19.360,534] <err> os: >>> ZEPHYR FATAL ERROR 3: Kernel oops on CPU 0
[00:00:19.360,565] <err> os: Fault during interrupt handling

[00:00:19.360,565] <err> os: Current thread: 0x20000980 (unknown)
[00:00:19.673,309] <err> os: Halting system

Environment (please complete the following information):

  • OS: Linux
  • Toolchain: gnuarmemb gcc version 9.2.0 (Arch Repository)
  • Commit SHA or Version used: 6baff1b

Additional context
Add any other context about the problem here. None.
@cvinayak cvinayak added bug The issue is a bug, or the PR is fixing a bug priority: high High impact/importance bug area: Bluetooth labels Feb 20, 2020
@cvinayak cvinayak added this to the v2.2.0 milestone Feb 20, 2020
@cvinayak cvinayak self-assigned this Feb 20, 2020
cvinayak added a commit to cvinayak/zephyr that referenced this issue Feb 20, 2020
@cvinayak
Bluetooth: controller: split: Fix assert on invalid packet sequence
b63d3ac 
Fix to remove assertion failure check on detecting invalid
packet sequence used by peer central and that no non-empty
packet was transmitted.

Fixes zephyrproject-rtos#22967.

Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
@cvinayak cvinayak mentioned this issue Feb 20, 2020
Merged
jhedberg pushed a commit that referenced this issue Feb 20, 2020
@cvinayak @jhedberg
Bluetooth: controller: split: Fix assert on invalid packet sequence
62c1e1a 
Fix to remove assertion failure check on detecting invalid
packet sequence used by peer central and that no non-empty
packet was transmitted.

Fixes #22967.

Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
@cvinayak cvinayak linked a pull request Apr 8, 2020 that will close this issue
[backport v2.2] Bluetooth: controller: split: Fix regression in handling invalid pkt seq #23547
Merged
@cvinayak cvinayak mentioned this issue Apr 8, 2020
Merged
alexandru-porosanu-nxp added a commit to alexandru-porosanu-nxp/zephyr that referenced this issue Apr 27, 2020
@alexandru-porosanu-nxp
bluetooth: controller: openisa: fix assert on invalid packet sequence
e4ed1bb 
This is a rework for OpenISA SW LL of
"62c1e1a52b Bluetooth: controller: split: Fix assert on invalid packet
sequence"

Fix to remove assertion failure check on detecting invalid
packet sequence used by peer central and that no non-empty
packet was transmitted.

Fixes zephyrproject-rtos#22967.

Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Signed-off-by: Alex Porosanu <[email protected]>
carlescufi pushed a commit that referenced this issue Apr 27, 2020
@alexandru-porosanu-nxp @carlescufi
bluetooth: controller: openisa: fix assert on invalid packet sequence
e08ceec 
This is a rework for OpenISA SW LL of
"62c1e1a52b Bluetooth: controller: split: Fix assert on invalid packet
sequence"

Fix to remove assertion failure check on detecting invalid
packet sequence used by peer central and that no non-empty
packet was transmitted.

Fixes #22967.

Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Signed-off-by: Alex Porosanu <[email protected]>
sandeepbrcm pushed a commit to Broadcom/zephyr that referenced this issue Apr 30, 2020
@alexandru-porosanu-nxp
bluetooth: controller: openisa: fix assert on invalid packet sequence
9049fe4 
This is a rework for OpenISA SW LL of
"62c1e1a52b Bluetooth: controller: split: Fix assert on invalid packet
sequence"

Fix to remove assertion failure check on detecting invalid
packet sequence used by peer central and that no non-empty
packet was transmitted.

Fixes zephyrproject-rtos#22967.

Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Signed-off-by: Alex Porosanu <[email protected]>
hakehuang pushed a commit to hakehuang/zephyr that referenced this issue Jun 20, 2020
@alexandru-porosanu-nxp @hakehuang
bluetooth: controller: openisa: fix assert on invalid packet sequence
2841461 
This is a rework for OpenISA SW LL of
"62c1e1a52b Bluetooth: controller: split: Fix assert on invalid packet
sequence"

Fix to remove assertion failure check on detecting invalid
packet sequence used by peer central and that no non-empty
packet was transmitted.

Fixes zephyrproject-rtos#22967.

Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Signed-off-by: Alex Porosanu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cvinayak cvinayak

Labels
area: Bluetooth bug The issue is a bug, or the PR is fixing a bug priority: high High impact/importance bug
Projects
None yet
Milestone
v2.2.0
2 participants
@cvinayak @aescolar