Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mesh: typo in condition in comp_add_elem of cfg_srv #22822

Closed
ToJIka4 opened this issue Feb 14, 2020 · 3 comments
Closed

mesh: typo in condition in comp_add_elem of cfg_srv #22822

ToJIka4 opened this issue Feb 14, 2020 · 3 comments
Assignees
@ToJIka4
Labels
area: Bluetooth Mesh bug The issue is a bug, or the PR is fixing a bug

Comments

@ToJIka4
Copy link
Contributor

ToJIka4 commented Feb 14, 2020

zephyr/subsys/bluetooth/mesh/cfg_srv.c

Line 53 in 1156412

4 + (elem->model_count * 2U) + (elem->vnd_model_count * 2U)) {

i think there should be
4 + (elem->model_count * 2U) + (elem->vnd_model_count * 4U)) {
@ToJIka4 ToJIka4 added the bug The issue is a bug, or the PR is fixing a bug label Feb 14, 2020
@aescolar
Copy link
Member

CC @jhedberg

@jhedberg
Copy link
Member

@ToJIka4 looks like you're right. Are you planning to submit a pull request?

@ToJIka4
Copy link
Contributor Author

ToJIka4 commented Feb 14, 2020

@jhedberg Okay, I'll do it

@ToJIka4 ToJIka4 mentioned this issue Feb 14, 2020
Merged
@aescolar aescolar assigned ToJIka4 and unassigned trond-snekvik Feb 14, 2020
ToJIka4 added a commit to ToJIka4/zephyr that referenced this issue Feb 16, 2020
@ToJIka4
Bluetooth: Mesh: typo in condition in comp_add_elem of cfg_srv
a43f423 
Vendor model IDs take up four (not two) bytes in the composition

Fixes zephyrproject-rtos#22822

Signed-off-by: Stephen Pliaskin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ToJIka4 ToJIka4

Labels
area: Bluetooth Mesh bug The issue is a bug, or the PR is fixing a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jhedberg @ToJIka4 @trond-snekvik @aescolar