Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards that have Kconfig warnings on hello_world. #22474

Closed
pabigot opened this issue Feb 4, 2020 · 3 comments · Fixed by #22831
Closed

boards that have Kconfig warnings on hello_world. #22474

pabigot opened this issue Feb 4, 2020 · 3 comments · Fixed by #22831
Assignees
Labels
area: Kconfig bug The issue is a bug, or the PR is fixing a bug priority: high High impact/importance bug

Comments

@pabigot
Copy link
Collaborator

pabigot commented Feb 4, 2020

Below is a list of boards that on current master produce Kconfig warnings when asked to build hello_world. Generated from something like:

for f in $(find boards -name '*_defconfig') ; do basename $f _defconfig; done \
  | sort \
  | uniq \
  | while read b ; do rm -rf build && echo $b && west build -b $b samples/hello_world 2>&1 | grep -i warning ; done \
  2>&1 | tee all-warn.log
(FIXED) atsamr21_xpro                 warning: IEEE802154_RF2XX (defined at drivers/ieee802154/Kconfig.rf2xx:6) was assigned the value 'y'
bbc_microbit                  warning: LOG_BUFFER_SIZE (defined at subsys/logging/Kconfig:224) was assigned the value '128' but
degu_evk                      warning: UART_SHELL_ON_DEV_NAME (defined at subsys/shell/Kconfig.backends:33) was assigned the value
em_starterkit_em7d_normal     warning: TRUSTED_EXECUTION_NONSECURE (defined at arch/Kconfig:146) was assigned the value 'y' but
esp32                         warning: ENTROPY_ESP32_RNG (defined at drivers/entropy/Kconfig.esp32:6) was assigned the value 'y'
frdm_kw41z                    warning: The choice symbol ADC_MCUX_ADC16_VREF_ALTERNATE (defined at drivers/adc/Kconfig.mcux:45)
mps2_an385                    warning: ZTEST_STACKSIZE (defined at subsys/testsuite/ztest/Kconfig:13) was assigned the value
odroid_go                     warning: ENTROPY_ESP32_RNG (defined at drivers/entropy/Kconfig.esp32:6) was assigned the value 'y'
olimex_stm32_e407             warning: TEST_RANDOM_GENERATOR (defined at subsys/random/Kconfig:8) was assigned the value 'y' but
olimex_stm32_p405             warning: TEST_RANDOM_GENERATOR (defined at subsys/random/Kconfig:8) was assigned the value 'y' but
qemu_cortex_m0                warning: LOG_BUFFER_SIZE (defined at subsys/logging/Kconfig:224) was assigned the value '128' but
qemu_xtensa                   warning: IPM_CONSOLE_STACK_SIZE (defined at drivers/console/Kconfig:169) was assigned the value
sam4s_xplained                warning: GPIO_SAM (defined at soc/arm/atmel_sam/same70/Kconfig.defconfig.series:53,
xt-sim                        warning: IPM_CONSOLE_STACK_SIZE (defined at drivers/console/Kconfig:169) was assigned the value
xt-sim_intel_s1000            warning: IPM_CONSOLE_STACK_SIZE (defined at drivers/console/Kconfig:169) was assigned the value

Relates to #22472 and #22417

@pabigot pabigot added the bug The issue is a bug, or the PR is fixing a bug label Feb 4, 2020
@pabigot
Copy link
Collaborator Author

pabigot commented Feb 4, 2020

@carlescufi @nashif fyi. Not sure if all of these would trigger CI errors. Some generate additional warnings.

@nashif
Copy link
Member

nashif commented Feb 4, 2020

none of those would trigger errors in CI, we have lots of kconfig warnings in many of the samples, those are being fixed slowly by ulf afaik.

@ulfalizer
Copy link
Collaborator

Those warnings are implemented in scripts/kconfig/kconfig.py and aren't turned into errors.

There's fewer of them than I thought at least. I'm a bit afraid of turning it into an error, because I suspect some samples might rely on turning on some option for all boards even though it only makes sense for some of them. Maybe some of those cases could be cleaned up though.

@jhedberg jhedberg added the priority: high High impact/importance bug label Feb 11, 2020
carlescufi added a commit to carlescufi/zephyr that referenced this issue Feb 14, 2020
Override the default log buffer size only when logging is actually
enabled.

See zephyrproject-rtos#22474.

Signed-off-by: Carles Cufi <[email protected]>
carlescufi added a commit to carlescufi/zephyr that referenced this issue Feb 14, 2020
For the non-secure image, the architecture still supports secure
execution, so express that in the defconfig.

See zephyrproject-rtos#22474.

Signed-off-by: Carles Cufi <[email protected]>
carlescufi added a commit to carlescufi/zephyr that referenced this issue Feb 14, 2020
Enable RNG only if the actual entropy generator is enabled.

See zephyrproject-rtos#22474.

Signed-off-by: Carles Cufi <[email protected]>
carlescufi added a commit to carlescufi/zephyr that referenced this issue Feb 14, 2020
In order to overrdie a choice one needs to define it again. Override it
by redefining it in the .defconfig file.

See zephyrproject-rtos#22474.

Signed-off-by: Carles Cufi <[email protected]>
carlescufi added a commit to carlescufi/zephyr that referenced this issue Feb 14, 2020
Set the ztest stack size only when ztest itself is enabled.

See zephyrproject-rtos#22474.

Signed-off-by: Carles Cufi <[email protected]>
carlescufi added a commit to carlescufi/zephyr that referenced this issue Feb 14, 2020
Enable RNG only if the actual entropy generator is enabled.

See zephyrproject-rtos#22474.

Signed-off-by: Carles Cufi <[email protected]>
carlescufi added a commit to carlescufi/zephyr that referenced this issue Feb 14, 2020
This board now has an entropy driver, no need to use the test one
anymore.

See zephyrproject-rtos#22474.

Signed-off-by: Carles Cufi <[email protected]>
carlescufi added a commit to carlescufi/zephyr that referenced this issue Feb 14, 2020
This board now has an entropy driver, no need to use the test one
anymore.

See zephyrproject-rtos#22474.

Signed-off-by: Carles Cufi <[email protected]>
carlescufi added a commit to carlescufi/zephyr that referenced this issue Feb 14, 2020
Override the default log buffer size only when logging is actually
enabled.

See zephyrproject-rtos#22474.

Signed-off-by: Carles Cufi <[email protected]>
carlescufi added a commit to carlescufi/zephyr that referenced this issue Feb 14, 2020
Set the IPM console stack size only when the console is enabled.

See zephyrproject-rtos#22474.

Signed-off-by: Carles Cufi <[email protected]>
carlescufi added a commit to carlescufi/zephyr that referenced this issue Feb 14, 2020
In the default configuration we want to enable the generic GPIO module
so that we avoid Kconfig warnings.

See zephyrproject-rtos#22474.

Signed-off-by: Carles Cufi <[email protected]>
carlescufi added a commit to carlescufi/zephyr that referenced this issue Feb 14, 2020
Set the IPM console stack size only when the console is enabled.

See zephyrproject-rtos#22474.

Signed-off-by: Carles Cufi <[email protected]>
carlescufi added a commit to carlescufi/zephyr that referenced this issue Feb 14, 2020
Fix up the board definition so that the actual board can at least be
processed by Kconfig.

See zephyrproject-rtos#22474.

Signed-off-by: Carles Cufi <[email protected]>
jhedberg pushed a commit that referenced this issue Feb 14, 2020
Override the default log buffer size only when logging is actually
enabled.

See #22474.

Signed-off-by: Carles Cufi <[email protected]>
jhedberg pushed a commit that referenced this issue Feb 14, 2020
For the non-secure image, the architecture still supports secure
execution, so express that in the defconfig.

See #22474.

Signed-off-by: Carles Cufi <[email protected]>
jhedberg pushed a commit that referenced this issue Feb 14, 2020
Enable RNG only if the actual entropy generator is enabled.

See #22474.

Signed-off-by: Carles Cufi <[email protected]>
jhedberg pushed a commit that referenced this issue Feb 14, 2020
In order to overrdie a choice one needs to define it again. Override it
by redefining it in the .defconfig file.

See #22474.

Signed-off-by: Carles Cufi <[email protected]>
jhedberg pushed a commit that referenced this issue Feb 14, 2020
Set the ztest stack size only when ztest itself is enabled.

See #22474.

Signed-off-by: Carles Cufi <[email protected]>
jhedberg pushed a commit that referenced this issue Feb 14, 2020
Enable RNG only if the actual entropy generator is enabled.

See #22474.

Signed-off-by: Carles Cufi <[email protected]>
jhedberg pushed a commit that referenced this issue Feb 14, 2020
This board now has an entropy driver, no need to use the test one
anymore.

See #22474.

Signed-off-by: Carles Cufi <[email protected]>
jhedberg pushed a commit that referenced this issue Feb 14, 2020
This board now has an entropy driver, no need to use the test one
anymore.

See #22474.

Signed-off-by: Carles Cufi <[email protected]>
jhedberg pushed a commit that referenced this issue Feb 14, 2020
Override the default log buffer size only when logging is actually
enabled.

See #22474.

Signed-off-by: Carles Cufi <[email protected]>
jhedberg pushed a commit that referenced this issue Feb 14, 2020
Set the IPM console stack size only when the console is enabled.

See #22474.

Signed-off-by: Carles Cufi <[email protected]>
jhedberg pushed a commit that referenced this issue Feb 14, 2020
In the default configuration we want to enable the generic GPIO module
so that we avoid Kconfig warnings.

See #22474.

Signed-off-by: Carles Cufi <[email protected]>
jhedberg pushed a commit that referenced this issue Feb 14, 2020
Set the IPM console stack size only when the console is enabled.

See #22474.

Signed-off-by: Carles Cufi <[email protected]>
jhedberg pushed a commit that referenced this issue Feb 14, 2020
Fix up the board definition so that the actual board can at least be
processed by Kconfig.

See #22474.

Signed-off-by: Carles Cufi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Kconfig bug The issue is a bug, or the PR is fixing a bug priority: high High impact/importance bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants