Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Coverity CID :207975] Logically dead code in subsys/net/l2/ppp/ipcp.c #22436

Closed
zephyrbot opened this issue Feb 3, 2020 · 0 comments · Fixed by #22744
Closed

[Coverity CID :207975] Logically dead code in subsys/net/l2/ppp/ipcp.c #22436

zephyrbot opened this issue Feb 3, 2020 · 0 comments · Fixed by #22744
Assignees
Labels
area: Networking bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug

Comments

@zephyrbot
Copy link
Collaborator

Static code scan issues found in file:

https://github.com/zephyrproject-rtos/zephyr/tree/a3e89e84a801d9bc048b0ee2177f0fb11d1a925a/subsys/net/l2/ppp/ipcp.c#L145

Category: Control flow issues
Function: ipcp_config_info_req
Component: Networking
CID: 207975

Details:

139         if (nack_idx > 0) {
140             struct net_buf *nack_buf;
141    
142             if (count_rej > 0) {
143                 code = PPP_CONFIGURE_REJ;
144             } else {
>>>     CID 207975:  Control flow issues  (DEADCODE)
>>>     Execution cannot reach this statement: "code = PPP_CONFIGURE_NACK;".
145                 code = PPP_CONFIGURE_NACK;
146             }
147    
148             /* Create net_buf containing options that are not accepted */
149             for (i = 0; i < MIN(nack_idx, ARRAY_SIZE(nack_options)); i++) {
150                 bool added;

Please fix or provide comments in coverity using the link:

https://scan9.coverity.com/reports.htm#v32951/p12996.

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the CODEOWNERS file.

@zephyrbot zephyrbot added bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug labels Feb 3, 2020
jukkar added a commit to jukkar/zephyr that referenced this issue Feb 12, 2020
If nack_idx > 0, then the count_rej must be > 0. This means that
the "code" variable will never be set to PPP_CONFIGURE_NACK.

Fixes zephyrproject-rtos#22436
Coverity-CID: 207975

Signed-off-by: Jukka Rissanen <[email protected]>
jhedberg pushed a commit that referenced this issue Feb 12, 2020
If nack_idx > 0, then the count_rej must be > 0. This means that
the "code" variable will never be set to PPP_CONFIGURE_NACK.

Fixes #22436
Coverity-CID: 207975

Signed-off-by: Jukka Rissanen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Networking bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants