Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Coverity CID :207978] Dereference after null check in subsys/canbus/canopen/CO_driver.c #22434

Closed
zephyrbot opened this issue Feb 3, 2020 · 0 comments
Assignees
Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug

Comments

@zephyrbot
Copy link
Collaborator

Static code scan issues found in file:

https://github.com/zephyrproject-rtos/zephyr/tree/a3e89e84a801d9bc048b0ee2177f0fb11d1a925a/subsys/canbus/canopen/CO_driver.c#L298

Category: Null pointer dereferences
Function: CO_CANtxBufferInit
Component: Other
CID: 207978

Details:

292                        bool_t syncFlag)
293     {
294         CO_CANtx_t *buffer;
295    
296         if (!CANmodule || (index >= CANmodule->tx_size)) {
297             LOG_ERR("failed to initialize CAN rx buffer, illegal argument");
>>>     CID 207978:  Null pointer dereferences  (FORWARD_NULL)
>>>     Dereferencing null pointer "CANmodule".
298             CO_errorReport(CANmodule->em, CO_EM_GENERIC_SOFTWARE_ERROR,
299                        CO_EMC_SOFTWARE_INTERNAL, 0);
300             return NULL;
301         }
302    
303         buffer = &CANmodule->tx_array[index];

Please fix or provide comments in coverity using the link:

https://scan9.coverity.com/reports.htm#v32951/p12996.

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the CODEOWNERS file.

@zephyrbot zephyrbot added bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug labels Feb 3, 2020
alexanderwachter added a commit to alexanderwachter/zephyr that referenced this issue Feb 4, 2020
There were two dereference after NULL check and logical dead code.

Fixes zephyrproject-rtos#22434
Fixes zephyrproject-rtos#22443
Fixes zephyrproject-rtos#22435
Coverity-CID: 207978
Coverity-CID: 207977
Coverity-CID: 207964

Signed-off-by: Alexander Wachter <[email protected]>
@jukkar jukkar closed this as completed in fd9733e Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug
Projects
None yet
Development

No branches or pull requests

2 participants