Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

watchdog subsystem has no system calls #21432

Closed
andrewboie opened this issue Dec 16, 2019 · 0 comments · Fixed by #21433
Closed

watchdog subsystem has no system calls #21432

andrewboie opened this issue Dec 16, 2019 · 0 comments · Fixed by #21433
Assignees
@andrewboie
Labels
area: Memory Protection bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug

Comments

@andrewboie
Copy link
Contributor

Describe the bug
We have no system calls defined for the watchdog subsystem API.

wdt_setup()
wdt_disable()
wdt_feed()

wdt_install_timeout() installs a callback handler and shouldn't have a system call. The rest of these APIs need them.

Impact
User mode threads can't interact with watchdog devices.
@andrewboie andrewboie added bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug labels Dec 16, 2019
@andrewboie andrewboie self-assigned this Dec 16, 2019
@andrewboie andrewboie mentioned this issue Dec 16, 2019
Merged
nashif pushed a commit to andrewboie/zephyr that referenced this issue Dec 18, 2019
@nashif
drivers: watchdog: add system calls
2029772 
wdt_install_timeout() was skipped as it installs an ISR-context
callback handler function. The rest are simple wrappers.

Added myself as the maintainer of the syscall handlers. WDT
subsystem appears to not currently have an owner.

Fixes: zephyrproject-rtos#21432

Signed-off-by: Andrew Boie <[email protected]>
Signed-off-by: Anas Nashif <[email protected]>
nashif pushed a commit that referenced this issue Dec 18, 2019
@nashif
drivers: watchdog: add system calls
13b8b41 
wdt_install_timeout() was skipped as it installs an ISR-context
callback handler function. The rest are simple wrappers.

Added myself as the maintainer of the syscall handlers. WDT
subsystem appears to not currently have an owner.

Fixes: #21432

Signed-off-by: Andrew Boie <[email protected]>
Signed-off-by: Anas Nashif <[email protected]>
andrewboie pushed a commit to andrewboie/zephyr that referenced this issue Jan 7, 2020
drivers: watchdog: add system calls
40e31c7 
wdt_install_timeout() was skipped as it installs an ISR-context
callback handler function. The rest are simple wrappers.

Added myself as the maintainer of the syscall handlers. WDT
subsystem appears to not currently have an owner.

Fixes: zephyrproject-rtos#21432

Signed-off-by: Andrew Boie <[email protected]>
Signed-off-by: Anas Nashif <[email protected]>
@andrewboie andrewboie mentioned this issue Jan 7, 2020
Merged
nashif pushed a commit that referenced this issue Jan 8, 2020
@nashif
drivers: watchdog: add system calls
c74ccf9 
wdt_install_timeout() was skipped as it installs an ISR-context
callback handler function. The rest are simple wrappers.

Added myself as the maintainer of the syscall handlers. WDT
subsystem appears to not currently have an owner.

Fixes: #21432

Signed-off-by: Andrew Boie <[email protected]>
Signed-off-by: Anas Nashif <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewboie andrewboie

Labels
area: Memory Protection bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

drivers: watchdog: add system calls andrewboie/zephyr
1 participant
@andrewboie