civetweb triggers an error on Windows with Git 2.24

[carlescufi]

Describe the bug
Using west and Git on Windows worked fine up until Git 2.23 (included).
When running west update using Git 2.24 on Windows, you get:

fatal: filename in tree entry contains backslash: '\'
error: https://github.com/zephyrproject-rtos/civetweb did not send all necessary objects

To Reproduce

On Windows, and with Git 2.24:

west init zephyr
cd zephyr
west update

Additional Context

• Git commit that introduced the issue: git/git@e1d911d
• Potential civetweb commit with the issue: zephyrproject-rtos/civetweb@4ac467e
• Civetweb issue: Error when cloning on Windows with Git 2.24: filename in tree entry contains backslash -- solved in Git 2.25 civetweb/civetweb#812
• Git for Windows issue: Git 2.24 breaks existing repositories: filename in tree entry contains backslash git-for-windows/git#2435

Workarounds

• Disable core.protectNTFS: git config --global core.protectNTFS false

• Update to Git 2.25

Environment (please complete the following information):

• OS: Windows
• Git for Windows 2.24
• Commit: civetweb 99129c5efc907ea613c4b73ccff07581feb58a7a

[mbolivar]

Users on the duplicate issue (#21321) reported the git config --global core.protectNTFS workaround did not work for them.

I would recommend:

1. applying the git config work around
2. backing up any local commits, then deleting the civetweb directory (modules/lib/civetweb) entirely
3. retrying west update

[andrewboie]

A note about this in our documentation would be nice, I tripped over this the other day.

[mbolivar]

A note about this in our documentation would be nice, I tripped over this the other day.

The patch fixing it appears to be making its way through review on mainline git and git-for-windows, so hopefully a new version with the fix will be out soon and we can just close this.

edit: the fix is merged. I've tested it and it solves this problem for me with core.protectNTFS enabled. We can look forward to a new git release with the fix within 10 days.

[carlescufi]

Closing this issue. See workarounds in the description

[szundi]

just a tip: if you get the error with git 2.26+, delete modules/lib/civetweb folder, then retry with west update, this fixed me some bad state