Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary CMake target indirection #21230

Open
mbolivar opened this issue Dec 6, 2019 · 4 comments
Open

Remove unnecessary CMake target indirection #21230

mbolivar opened this issue Dec 6, 2019 · 4 comments
Assignees
Labels
area: Build System Enhancement Changes/Updates/Additions to existing features priority: low Low impact/importance bug

Comments

@mbolivar
Copy link
Contributor

mbolivar commented Dec 6, 2019

Is your enhancement proposal related to a problem? Please describe.

As prep work for #13672, various changes were made to the build system which add extra layers of indirection for target names. One example commit is 1b86fb9.

Since this PR was rejected, the indirection is not necessary and will not be necessary, so it should be removed.

I'm not sure if any other indirection besides targets should be looked at.

Describe the solution you'd like

Remove extra indirection and refer to target names directly from CMake, e.g. offsets_h instead of ${OFFSETS_H_TARGET}.

@mbolivar mbolivar added Enhancement Changes/Updates/Additions to existing features area: Build System labels Dec 6, 2019
@mbolivar mbolivar added this to the v2.2.0 milestone Dec 6, 2019
@mbolivar
Copy link
Contributor Author

mbolivar commented Dec 6, 2019

FYI @carlescufi @SebastianBoe @tejlmand @hakonfam

I'm not sure about the milestone, but this should be done "eventually".

@mbolivar mbolivar added the priority: low Low impact/importance bug label Dec 6, 2019
@SebastianBoe
Copy link
Collaborator

Agreed

@tejlmand
Copy link
Collaborator

agreed/

@mbolivar mbolivar removed this from the v2.2.0 milestone Jan 8, 2020
@zephyrbot
Copy link
Collaborator

Hi @tejlmand,

This issue, marked as an Enhancement, was opened a while ago and did not get any traction. It was just assigned to you based on the labels. If you don't consider yourself the right person to address this issue, please re-assing it to the right person.

Please take a moment to review if the issue is still relevant to the project. If it is, please provide feedback and direction on how to move forward. If it is not, has already been addressed, is a duplicate, or is no longer relevant, please close it with a short comment explaining the reason.

@mbolivar you are also encouraged to help moving this issue forward by providing additional information and confirming this request/issue is still relevant to you.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Build System Enhancement Changes/Updates/Additions to existing features priority: low Low impact/importance bug
Projects
None yet
Development

No branches or pull requests

4 participants