sanitycheck corrupts stty in some cases

[pabigot]

Manual runs of sanitycheck since 83fc06a periodically complete with the following stty settings changed:

-brkint -icrnl -ixon -icanon -echo

This is something like what I would expect if stty sane was not invoked at a necessary time.

I can reproduce this with some regularity with:

sanitycheck -p mps2_an385 -T tests/kernel/

but it doesn't always leave the terminal corrupted. There's some evidence it can also affect a subset of the flags.

[nashif]

issue confirmed.

[aescolar]

Note for whoever faces it, you can always write
stty sane
and press enter (even if you dont get the echo)
or in the worst case
Ctrl+J stty saneCtrl+J

[nashif]

a fix was added in 1fe1f3a