Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing 'clocks' on most nodes with 'compatible = "nxp,kinetis-usbd"' #17664

Closed
ulfalizer opened this issue Jul 19, 2019 · 2 comments · Fixed by #17670
Closed

Missing 'clocks' on most nodes with 'compatible = "nxp,kinetis-usbd"' #17664

ulfalizer opened this issue Jul 19, 2019 · 2 comments · Fixed by #17670
Labels
area: Devicetree bug The issue is a bug, or the PR is fixing a bug

Comments

@ulfalizer
Copy link
Collaborator

dts/bindings/usb/nxp,kinetis-usbd.yaml says that any node with that binding must have a clocks property, but only a few nodes with compatible = "nxp,kinetis-usbd" have a clocks property.

List for reference:

$ git grep nxp,kinetis-usbd
boards/arm/frdm_k64f/frdm_k64f.dts:     compatible = "nxp,kinetis-usbd";
boards/arm/frdm_kl25z/frdm_kl25z.dts:   compatible = "nxp,kinetis-usbd";
boards/arm/usb_kw24d512/usb_kw24d512.dts:       compatible = "nxp,kinetis-usbd";
dts/arm/nxp/nxp_k6x.dtsi:                       compatible = "nxp,kinetis-usbd";
dts/arm/nxp/nxp_kl25z.dtsi:                     compatible = "nxp,kinetis-usbd";
dts/arm/nxp/nxp_kw2xd.dtsi:                     compatible = "nxp,kinetis-usbd";
dts/arm/nxp/nxp_rt.dtsi:                        compatible = "nxp,kinetis-usbd";
dts/arm/nxp/nxp_rt.dtsi:                        compatible = "nxp,kinetis-usbd";
dts/bindings/usb/nxp,kinetis-usbd.yaml:      constraint: "nxp,kinetis-usbd"

This leads to failures in #17660, which turns missing category: required properties into an error.

Not familiar enough with how this is used to know what the proper solution is. A quickfix would be to make clocks optional instead in the binding (category: optional).

@ulfalizer ulfalizer added the bug The issue is a bug, or the PR is fixing a bug label Jul 19, 2019
@ulfalizer
Copy link
Collaborator Author

CC @pizi-nordic @jfischer-phytec-iot @galak

@pizi-nordic
Copy link
Collaborator

pizi-nordic commented Jul 19, 2019

It looks that I forgot cleaning this out while refactoring #16957 N-th time. I will create PR which will make the clocks optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Devicetree bug The issue is a bug, or the PR is fixing a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants