Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/kernel/timer/timer_api/kernel.timer sporadically (high frequency) fails in CI on qemu-xtensa #16487

Closed
nashif opened this issue May 29, 2019 · 4 comments
Assignees
Labels
bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug
Milestone

Comments

@nashif
Copy link
Member

nashif commented May 29, 2019

***** Booting Zephyr OS zephyr-v1.14.0-1113-g8806967aed2e *****
Running test suite timer_api
===================================================================
starting test - test_timer_duration_period
PASS - test_timer_duration_period
===================================================================
starting test - test_timer_period_0

    Assertion failed at ./tests/kernel/timer/timer_api/src/main.c:167: test_timer_period_0: tdata.expire_cnt == 1 is false

FAIL - test_timer_period_0
===================================================================
starting test - test_timer_expirefn_null
PASS - test_timer_expirefn_null
===================================================================
starting test - test_timer_periodicity
PASS - test_timer_periodicity
===================================================================
starting test - test_timer_status_get
PASS - test_timer_status_get
===================================================================
starting test - test_timer_status_get_anytime
PASS - test_timer_status_get_anytime
===================================================================
starting test - test_timer_status_sync
PASS - test_timer_status_sync
===================================================================
starting test - test_timer_k_define

    Assertion failed at ./tests/kernel/timer/timer_api/src/main.c:394: test_timer_k_define: tdata.expire_cnt == 4 is false

FAIL - test_timer_k_define
===================================================================
starting test - test_timer_user_data
PASS - test_timer_user_data
===================================================================
starting test - test_timer_remaining_get
PASS - test_timer_remaining_get
===================================================================
Test suite timer_api failed.
===================================================================
PROJECT EXECUTION FAILED
@nashif nashif added bug The issue is a bug, or the PR is fixing a bug priority: high High impact/importance bug labels May 29, 2019
@nashif nashif changed the title tests/kernel/timer/timer_api/kernel.timer constantly fails in CI on qemu-xtensa tests/kernel/timer/timer_api/kernel.timer sporadically (high frequency) fails in CI on qemu-xtensa May 29, 2019
@nashif nashif self-assigned this Jun 4, 2019
@rljordan-zz rljordan-zz assigned andyross and unassigned nashif Aug 13, 2019
@andrewboie
Copy link
Contributor

andrewboie commented Aug 13, 2019

I don't think this should be high, only seen with QEMU which is known to have timing issues since we don't use icount

In fact, if this is a QEMU timing issue, we should just close this, since that is adequately covered by other bugs

@andyross
Copy link
Contributor

I'll take spurious bugs, regardless. Drop to medium for now, will do another pass with a modified rig to rule out timing on tests like this again.

@andyross andyross added priority: medium Medium impact/importance bug and removed priority: high High impact/importance bug labels Aug 13, 2019
@jenmwms jenmwms added this to the v2.0.0 milestone Aug 23, 2019
@andyross
Copy link
Contributor

This had 1400+ iterations for me over the weekend using the tooling in #18656 without a single failure. I buy that this could certainly be more likely to fail on this platform and this test than others, it just doesn't seem like it's any different fundamentally than the timing artifacts we already know about.

I think we should close this. If the failures are so frequent that they're impacting CI reliability, maybe we can come up with some kind of workaround.

@nashif
Copy link
Member Author

nashif commented Aug 27, 2019

agree with @andyross. I can't reproduce this anymore and it does not show up in CI anymore, must have been fixed somehow...

@nashif nashif closed this as completed Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug
Projects
None yet
Development

No branches or pull requests

4 participants