Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move NATS support from sample to a library + API #1468

Closed
nashif opened this issue Sep 12, 2017 · 1 comment
Closed

Move NATS support from sample to a library + API #1468

nashif opened this issue Sep 12, 2017 · 1 comment
Assignees
@jukkar
Labels
area: Networking Enhancement Changes/Updates/Additions to existing features

Comments

@nashif
Copy link
Member

nashif commented Sep 12, 2017

samples/net/nats/src/nats.c right now contains the bulk of the NATS protocol and is not considered part of Zephyr. It needs to be moved to be part of Zephyr OS and provide an API that applications can use instead of including the implementation in the application directly.
@nashif nashif added the Enhancement Changes/Updates/Additions to existing features label Sep 12, 2017
nagineni pushed a commit to nagineni/zephyr that referenced this issue Nov 20, 2017
@grgustaf
[net] Acquire server until closed; store connections in server
f08230a 
The server object was being freed immediately if JS lost its reference
to it; instead it should only be freed if explicitly closed and all its
connections are closed.

To track this properly, store open connections within the server handle
they are associated with, and store a global list of servers instead of
connections.

Fixes zephyrproject-rtos#1468

Signed-off-by: Geoff Gustafson <[email protected]>
@jukkar
Copy link
Member

jukkar commented Jan 27, 2020

NATS sample app was just recently removed so this issue can be closed.

@jukkar jukkar closed this as completed Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jukkar jukkar

Labels
area: Networking Enhancement Changes/Updates/Additions to existing features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nashif @jukkar @galak