Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: icmp4: Zephyr strips record route and time stamp options #14668

Closed
rmstoi opened this issue Mar 19, 2019 · 6 comments · Fixed by #19470
Closed

net: icmp4: Zephyr strips record route and time stamp options #14668

rmstoi opened this issue Mar 19, 2019 · 6 comments · Fixed by #19470
Assignees
@rveerama1
Labels
area: Networking Enhancement Changes/Updates/Additions to existing features

Comments

@rmstoi
Copy link
Collaborator

rmstoi commented Mar 19, 2019 •
edited
Loading

If echo server receives ICMPv4 echo request with IPv4 options Record Route and Time Stamp it does not include them in echo response. According to RFC 1122 3.2.2.6 these options must be updated and included in the echo response.

ipv4-timestamp-recordroute.pcap.gz
@rmstoi rmstoi added bug The issue is a bug, or the PR is fixing a bug area: Networking labels Mar 19, 2019
@tbursztyka
Copy link
Collaborator

didn't you say that linux was dropping the options, when I fixed the ipv4 options parsing?

@tbursztyka
Copy link
Collaborator

oh btw, we don't support ANY ipv4 options. So it's not a bug, we just don't support any ipv4 options, period.

If we want to support it, that's an enhancement

@tbursztyka tbursztyka removed the bug The issue is a bug, or the PR is fixing a bug label Mar 19, 2019
@rmstoi
Copy link
Collaborator Author

rmstoi commented Mar 19, 2019

didn't you say that linux was dropping the options, when I fixed the ipv4 options parsing?

Please add reference, to where I said that

@tbursztyka
Copy link
Collaborator

@rmstoi It was on IRC. But that was about #11618 so probably not about these same options. nevermind

@rmstoi rmstoi added the Feature Request A request for a new feature label Mar 20, 2019
@jukkar jukkar added Enhancement Changes/Updates/Additions to existing features and removed Feature Request A request for a new feature labels May 22, 2019
@jukkar
Copy link
Member

jukkar commented May 22, 2019

This is more like an enhancement than feature.

@rveerama1 rveerama1 assigned rveerama1 and unassigned jukkar Sep 12, 2019
@rveerama1 rveerama1 mentioned this issue Sep 30, 2019
Merged
@rmstoi
Copy link
Collaborator Author

rmstoi commented Sep 30, 2019

pcap of this issue:

Linux DUT test PASS
linux-ipv4-timestamp-recordroute.pcap.gz

Zephyr DUT PR #19470 test FAIL
zephyr-pr-19470.pcap.gz

FAIL reason is:
"FAIL: First Record Route entry is not DUT's IPv4 address. Time Stamp Route entry is not DUT's IPv4 address. "

rveerama1 added a commit to rveerama1/zephyr that referenced this issue Dec 13, 2019
@rveerama1
net: icmpv4: Add support for Timestamp and RR
9d2776f 
Timestamp and RecordRoute options are supported
in only ICMPv4 EchoRequest call as per
RFC 1122 3.2.2.6.

Fixes zephyrproject-rtos#14668

Signed-off-by: Ravi kumar Veeramally <[email protected]>
jukkar pushed a commit that referenced this issue Dec 16, 2019
@rveerama1 @jukkar
net: icmpv4: Add support for Timestamp and RR
1c33951 
Timestamp and RecordRoute options are supported
in only ICMPv4 EchoRequest call as per
RFC 1122 3.2.2.6.

Fixes #14668

Signed-off-by: Ravi kumar Veeramally <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rveerama1 rveerama1

Labels
area: Networking Enhancement Changes/Updates/Additions to existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for IPv4 header options in EchoRequest rveerama1/zephyr
4 participants
@jukkar @tbursztyka @rveerama1 @rmstoi