mcux-sdk: use Zephyr's MIN/MAX/ARRAY_SIZE #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When HAL is used in the context of Zephyr, use Zephyr's MIN/MAX/ARRAY_SIZE to avoid namespace collisions. Signed-off-by: Gerard Marull-Paretas <[email protected]>
|
Alternative to #196 |
stephanosio
approved these changes
Oct 18, 2022
The KB define is unnecessarily polluting the namespace (clashes with zephyr/sys/util.h definition) since it is only used once in a source file. To fix the problem, definition has been moved to the source file. Signed-off-by: Gerard Marull-Paretas <[email protected]>
de-nordic
approved these changes
Oct 20, 2022
dleach02
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When HAL is used in the context of Zephyr, use Zephyr's MIN/MAX/ARRAY_SIZE to avoid namespace collisions.
Also moved KB definition to the only source file using it (was also causing collisions in Zephyr).
Signed-off-by: Gerard Marull-Paretas [email protected]