lpc54114: Remove offsets_short.h inclusion. #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes unnecessary inclusion of offsets_short.h in the LPC54114 start-up code. The offsets_short.h is a kernel private header and must not be included by non-kernel components. The kernel and arch private header directories will be removed from the compiler include path in the near future. For more details, Refer to the issue zephyrproject-rtos/zephyr#20119. Signed-off-by: Stephanos Ioannidis <[email protected]>
galak
approved these changes
Nov 1, 2019
|
@galak Could you merge this so zephyrproject-rtos/zephyr#20119 CI build test can pass? |
You can update west.yaml in 20119 to point to this PR first. See https://docs.zephyrproject.org/latest/guides/modules.html?highlight=modules#process |
stephanosio
added a commit
to stephanosio/zephyr
that referenced
this pull request
Nov 6, 2019
Remove unnecessary inclusion of offsets_short.h in the LPC54114 start-up code. See zephyrproject-rtos/hal_nxp#17. Signed-off-by: Stephanos Ioannidis <[email protected]>
andrewboie
pushed a commit
to zephyrproject-rtos/zephyr
that referenced
this pull request
Nov 7, 2019
Remove unnecessary inclusion of offsets_short.h in the LPC54114 start-up code. See zephyrproject-rtos/hal_nxp#17. Signed-off-by: Stephanos Ioannidis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes unnecessary inclusion of offsets_short.h in the
LPC54114 start-up code.
The offsets_short.h is a kernel private header and must not be included
by non-kernel components. The kernel and arch private header
directories will be removed from the compiler include path in the near
future.
For more details, Refer to the issue zephyrproject-rtos/zephyr#20119.
Signed-off-by: Stephanos Ioannidis [email protected]