Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ad-hoc additional fields rather then explicitly setting a field name as "additional_fields" #15

Closed
e-lo opened this issue Apr 23, 2020 · 2 comments · Fixed by #17

Comments

@e-lo
Copy link
Contributor

e-lo commented Apr 23, 2020

  1. it is confusing what it is.
  2. what if you have multiple?
@ssmith55
Copy link
Collaborator

Agreed. What we had was a placeholder, with the intent of allowing ad-hoc additional fields.

@ianberg-volpe ianberg-volpe mentioned this issue May 8, 2020
@ssmith55 ssmith55 linked a pull request May 9, 2020 that will close this issue
@joshchea
Copy link

User defined or custom fields could have any name except the required/predefined GMNS field names for the network object in question. This could be enforced by issuing a warning/error when parsing the data in the validation tool by checking set membership against predefined attribute names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants