-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add #[WithStory]
attribute
#728
Conversation
0f80faa
to
dd93952
Compare
So this would only load the story before the first test in a class? |
That's what I have in mind, but I'm afraid it's would be too much complicated, we have to hack into dama and reset database for this, but I'll give this a chance in another PR |
This is soooo cool, I love it!
Yeah, this feels complex and I'm worried about breaking test isolation. Kind of a sub-global state... |
super nice ❤️
yes I think I won't even try, I've checked how dama works and it would require some ugly stuff to make this work. BTW, the PR is RFR now, I've added some docs as well. |
e08cd21
to
5cc3170
Compare
5cc3170
to
61b07ae
Compare
Can you move the versionadded/warnings to directly below the subtitle? I feel like people might get excited about the feature and start using without reading below. :) |
56cf744
to
60979ee
Compare
#[WithStory]
attribute
60979ee
to
b2d99fd
Compare
b2d99fd
to
baa1fd4
Compare
fixes #430
I think that only an attribute related to stories is useful, I don't see any practical usage of an attribute related to factories
TODO:
only load story once if it is added to a class? Maybe this will be conditioned by a booleanwon't be made