-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
To repair the open image dialog is very slow in Chrome #189
Comments
Thanks for documenting the workaround.
|
|
I don't see a significant different in open time for the image dialog between the handler w/out SVG and the default. I'm on Chrome 57. |
I have the same concern which is that I also do not experience and noticeable slowdown or speedup with the svg removal whereas the issue reports a 6-10s slowdown. I was able to reproduce the original issue slab/quill#1090 in addition to the issue being well documented on StackOverflow and Chrome bug reports and promptly accepted the PR. |
Thanks @jhchen @alexkrolick |
@raisezhang How long does it take you to open the default and non-SVG file dialogs that @alexkrolick posted? |
default: about 8 seconds non-SVG: about 1 seconds macOS Sierra 10.12.2 |
Ok thanks for the demo - this is Chrome 57 on Windows I'm assuming? |
This actually a Chrome bug: https://bugs.chromium.org/p/chromium/issues/detail?id=638874 @jhchen what's your policy on working around platform bugs? |
@raisezhang if anyone feels the need to mitigate the issue before Chrome fixes it they should be able to follow your patch. |
I don't think the linked Chrome bug is describing this issue. There was previously an Issue with the same side effect slab/quill#1090 but this Issue has to do with svgs specifically. |
The SVG-specific bug is tracking here, although not much progress has been made: https://bugs.chromium.org/p/chromium/issues/detail?id=678507 |
Okay thanks for the link. In any case it Quill's policy is to not rely on browsers to fix anything if possible and to work around or fix in another layer. In some ways the existence of Quill owes to the fact that browsers have not fixed the many issues surrounding contenteditable. |
This issue mainly solve the quill in chrome52+ image dialog is very slow bugs!
In fact this problem the quill trunk has been repair the question. slab/quill#1265, slab/quill#1260
But the quill is not yet released the latest code to the NPM and the react-quill isn't reference to the latest code.
So to solve this problem, need to temporary hack, the code is as follows:
reference: https://github.com/YouHan26/quill/blob/494d87b7388ca9d6e65ee396980f0554b7edb40f/themes/base.js#L128
The text was updated successfully, but these errors were encountered: