This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
added connection type to allow force new connection #7396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failed due to use of undefined constant PGSQL_CONNECT_ASYNC. This constant is only available if the PGSQL extension is enabled in PHP. |
| $this->connection->setType($type); | ||
| $reflectionProperty = new \ReflectionProperty($this->connection, 'type'); | ||
| $reflectionProperty->setAccessible(true); | ||
| $this->assertEquals($type, $reflectionProperty->getValue($this->connection)); |
There was a problem hiding this comment.
Instead of ReflectionProperty you can use readAttribute() for this:
public function testSetConnectionType()
{
$type = PGSQL_CONNECT_FORCE_NEW;
$this->connection->setType($type);
$this->assertEquals($type, self::readAttribute($this->connection, 'type'));
}There was a problem hiding this comment.
Cool, thanks for the feedback!
|
I think you can add : if (! extension_loaded('pgsql')) {
$this->markTestSkipped('pgsql extension not loaded');
} |
| */ | ||
| public function testSetConnectionTypeException() | ||
| { | ||
| $this->connection->setType(3); |
There was a problem hiding this comment.
This test also needs to be skipped if pgsql is not present, as it's exercising code that will check for those constants. I can make that change on merge.
weierophinney
added a commit
that referenced
this pull request
May 4, 2015
added connection type to allow force new connection
weierophinney
added a commit
that referenced
this pull request
May 4, 2015
weierophinney
added a commit
that referenced
this pull request
May 4, 2015
weierophinney
added a commit
that referenced
this pull request
May 4, 2015
|
|
|
I'll create a PR that fixes this. |
weierophinney
added a commit
to weierophinney/zendframework
that referenced
this pull request
May 4, 2015
Raise a RuntimeException when the method is invoked in versions less than 5.6, and skip unit tests in those situations as well. Also fixes several long lines.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7377
Connection now allows to specify type.