This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Allowing the route match controller to override the controller class #7336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis reporting what I believe are false positives. 5.3 and 5.6 failed, but the Mvc test block looks clean |
|
I like it — clean implementation, and fully backwards compatible (because it's opt-in)! Merging for 2.4. |
weierophinney
added a commit
that referenced
this pull request
Mar 19, 2015
…-route-match Allowing the route match controller to override the controller class
weierophinney
added a commit
that referenced
this pull request
Mar 19, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to InjectTemplateListener to allow for the RouteMatch "controller" parameter to override the controller's class.
Use case is to handle controllers that are built by abstract factories, which require extra rendering logic because this resolver will always use the get_class() method over what's in the RouteMatch (oftentimes a base or parent class).
Also helpful with the reverse, which is extended or decorator controllers appearing (and rendering) as their parent controller.
The behavior is off by default for backwards compatibility (1 test broke, so close).