This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Add flexibility to FlashMessenger by determining hops as parameter. #7242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ops as parameter.
|
Also hops flexibility can be implemented on error, warning, success and info messages. |
|
Please add a unit test for this functionality. |
|
Test added |
|
We have a problem at this point. The feature you're suggesting conflicts with a feature already in the develop branch, which adds I'm going to go ahead and merge this, but will put |
weierophinney
added a commit
that referenced
this pull request
Mar 19, 2015
…senger Add flexibility to FlashMessenger by determining hops as parameter. Conflicts: library/Zend/Mvc/Controller/Plugin/FlashMessenger.php
weierophinney
added a commit
that referenced
this pull request
Mar 19, 2015
|
Merged to develop for release with 2.4. |
|
Marking as a BC break, as it changes signature. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional flexibility for FlashMessenger. It's better to determine hops as parameter.