This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Error in FirePhp log writer #7213
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weierophinney
added a commit
that referenced
this pull request
Feb 25, 2015
Error in FirePhp log writer
|
Merged to develop for release with 2.4. |
weierophinney
added a commit
to zendframework/zend-log
that referenced
this pull request
May 15, 2015
Error in FirePhp log writer
weierophinney
added a commit
to zendframework/zend-log
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use statement @ line 17 is trying to load a class with a relative namespace path. This is not valid in PHP. if you use the full namespace the unit tests will fail.
I have removed the use statement and just used the namespace FirePhp\FirePhpInterface in the instanceof statement and reversed the condition.
Fixes #7202