This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Update PostCode.php #7176
Closed
Update PostCode.php #7176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exclude french zip codes with invalid departments : 00, 96 et 99. Exclude invalid Norway zip code : 0000.
|
@SamHecquet this requires additional tests with example codes from those areas |
|
98 is not a valid French postcode neither, as far as I know :o. EDIT : Ha si... Nouméa. My mistake. |
|
I'd like to schedule for 2.4.0... but could really use some unit tests, @SamHecquet ... |
|
24-hour warning; I need tests by tomrrow, 19 March 2015, if you want this included in 2.4; otherwise, I'll remove the milestone, and we can review at a later date. |
|
@weierophinney, sorry for the delay (and to failing my commit 44f0408 message "git") |
weierophinney
added a commit
that referenced
this pull request
Mar 19, 2015
|
Merged to develop for release with 2.4. |
weierophinney
added a commit
to zendframework/zend-i18n
that referenced
this pull request
May 15, 2015
…atch-2 Update PostCode.php
weierophinney
added a commit
to zendframework/zend-i18n
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exclude french zip codes with invalid departments : 00, 96 et 99.
Exclude invalid Norway zip code : 0000.