This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
SessionManagerFactory with ArrayStorage triggers undefined variable #7127
Closed
Martin-P
wants to merge
2
commits into
zendframework:master
from
Martin-P:hotfix/sessionmanager-undefined-var
Closed
SessionManagerFactory with ArrayStorage triggers undefined variable #7127
Martin-P
wants to merge
2
commits into
zendframework:master
from
Martin-P:hotfix/sessionmanager-undefined-var
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Ocramius marked as 2.4.0 or 2.3.5 ? @weierophinney if the next dev version is 2.3.5dev ( https://github.com/zendframework/zf2/blob/master/library/Zend/Version/Version.php#L23 ) the milestone need to be created ... |
@samsonasik I created the milestone (sorry, was just too lazy :P ) |
$oldSessionData = $_SESSION; | ||
$oldSessionData = array(); | ||
if (isset($_SESSION)) { | ||
$oldSessionData = $_SESSION; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe $oldSessionData = isset($_SESSION) ? $_SESSION : array();
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@malukenho no big deal, IMO
gianarb
pushed a commit
to zendframework/zend-session
that referenced
this pull request
May 15, 2015
…-with-array-storage-fails-with-notice' Close zendframework/zendframework#7127
gianarb
pushed a commit
to zendframework/zend-session
that referenced
this pull request
May 15, 2015
…-with-array-storage-fails-with-notice' into develop Close zendframework/zendframework#7127 Forward port zendframework/zendframework#7127
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
Zend\Session\Service\SessionManagerFactory
withArrayStorage
security fix ddbf43a triggers an undefined variable:This PR fixes that issue.