This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Improved disabled inputs testing when binding values into fieldset object #7109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not enough to test that 'disabled' attribute exists, should also check that its value is something else than null or false or empty.
|
Actually, this requires a test case as well. |
weierophinney
added a commit
that referenced
this pull request
Jan 13, 2015
Improved disabled inputs testing when binding values into fieldset object
weierophinney
added a commit
that referenced
this pull request
Jan 13, 2015
- Added unit test for behavior added with this pull request
weierophinney
added a commit
that referenced
this pull request
Jan 13, 2015
|
I've written and committed a test case to validate the change. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not enough to test that 'disabled' attribute exists, should also check that its value is something else than null or false or empty.