This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Scope objectKey in nested partialLoop call #7093
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@larsnystrom can you please provide a test-case that verifies what is explained in #3758? |
| * | ||
| * @param string $key | ||
| */ | ||
| public function setObjectKey($key) |
There was a problem hiding this comment.
That method overrides setObjectKey() in Partial, which we inherit. Maybe I should've added that to the docblock, but I'm unsure of the syntax.
There was a problem hiding this comment.
I don't think I can use that tag for other things than classes.
There was a problem hiding this comment.
You can use that for anything that is API overriding/implementing ;-)
There was a problem hiding this comment.
Guess my documentation skills needs to be improved then :) Pushed a fix for it now.
|
I added a test for issue #3758. My commit should make it pass. |
| @@ -0,0 +1,10 @@ | |||
| <?php | |||
| $vars = $this->vars(); | |||
| if (empty($vars)) : | |||
There was a problem hiding this comment.
use curly braces ( { } ) instead https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-2-coding-style-guide.md#51-if-elseif-else
There was a problem hiding this comment.
nvm, it ignored in .php_cs config ;)
There was a problem hiding this comment.
Oh well, I've already pushed a fix :)
| * | ||
| * @return self | ||
| */ | ||
| protected function nestObjectKey() |
There was a problem hiding this comment.
I will make these new methods private upon merge, since they really are a deep implementation detail
Ocramius
added a commit
that referenced
this pull request
Jan 3, 2015
Ocramius
added a commit
that referenced
this pull request
Jan 3, 2015
Ocramius
added a commit
that referenced
this pull request
Jan 3, 2015
Ocramius
added a commit
that referenced
this pull request
Jan 3, 2015
Ocramius
added a commit
that referenced
this pull request
Jan 3, 2015
Ocramius
added a commit
that referenced
this pull request
Jan 3, 2015
Ocramius
added a commit
that referenced
this pull request
Jan 3, 2015
Ocramius
added a commit
that referenced
this pull request
Jan 3, 2015
Ocramius
added a commit
that referenced
this pull request
Jan 3, 2015
Ocramius
added a commit
that referenced
this pull request
Jan 3, 2015
… given to the PartialLop helper
Ocramius
added a commit
that referenced
this pull request
Jan 3, 2015
|
@larsnystrom merged, thanks! |
gianarb
pushed a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
…ename properties for better clarity
gianarb
pushed a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
…aking scope emulation variables `private`
gianarb
pushed a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
…$key` may be `null`
gianarb
pushed a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
…$key` may be `null`
gianarb
pushed a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
…ixed return type (`self`)
gianarb
pushed a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
…ixed return type (`self`), leveraging parent class API
gianarb
pushed a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
…emoving minor code duplication
gianarb
pushed a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
…/++/+= 1 - s/--/-= 1
gianarb
pushed a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
…aking nesting/unNesting API `private`
gianarb
pushed a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
…efactoring `PartialLoop` `$values` extraction logic into its own private method
gianarb
pushed a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
…dding `@group` annotation for newly introduced tests
gianarb
pushed a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
…dding test for non-iterable data exception message
gianarb
pushed a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
…etter exception message in case of non-iterable values given to the PartialLop helper
gianarb
pushed a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
…dding test for non-iterable object data exception message
gianarb
pushed a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
…endframework#3758-scope-object-key-in-nested-partialloop-calls' Close zendframework/zendframework#7093 Close zendframework/zendframework#3758
gianarb
pushed a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
…endframework#3758-scope-object-key-in-nested-partialloop-calls' into develop Close zendframework/zendframework#7093 Close zendframework/zendframework#3758 Forward port zendframework/zendframework#7093 Forward port zendframework/zendframework#3758
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #3758 and introduces an
objectKeyStackwhich scopes theobjectKeyto anestingLevel. This allows nested calls with thePartialLoopView Helper where each level of nesting uses it's own or a parent'sobjectKey.It is not clear whether this is a bug fix or a feature request which introduces a BC break, but at least no tests are failing. I'd be happy to write a test case for this fix if necessary.
This is my first pull request ever, so please be gentle when providing feedback :)