Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Code improvement - removed unused variable #6919

Merged
merged 2 commits into from
Nov 23, 2014
Merged

Code improvement - removed unused variable #6919

merged 2 commits into from
Nov 23, 2014

Conversation

dkemper
Copy link
Contributor

@dkemper dkemper commented Nov 23, 2014

I found this method and removed the else block + the $sqlString variable. The variable assignment is not necessary.

For me the readability is still the same.

@macnibblet
Copy link
Contributor

Heya 👍

While you are at it, can you please add docblocks to the methods that are missing them ?

@Ocramius Ocramius self-assigned this Nov 23, 2014
@Ocramius Ocramius added this to the 2.3.4 milestone Nov 23, 2014
Ocramius added a commit that referenced this pull request Nov 23, 2014
@Ocramius
#6919 - add SqlInterface#getSqlString() return value signature
6f0c15f
Ocramius added a commit that referenced this pull request Nov 23, 2014
@Ocramius
#6919 - fixed Sql#getSqlStringForSqlObject() return value
e140e06
Ocramius added a commit that referenced this pull request Nov 23, 2014
@Ocramius
Merge branch 'cs/#6919-remove-unused-zend-db-sql-sql-variable' into d…
bfd3994 
…evelop

Close #6919
Forward port #6919
@Ocramius Ocramius merged commit afc9490 into zendframework:master Nov 23, 2014
Ocramius added a commit that referenced this pull request Nov 23, 2014
@Ocramius
Merge branch 'cs/#6919-remove-unused-zend-db-sql-sql-variable'
a20582c 
Close #6919
@Ocramius
Copy link
Member

Merged, thanks @dkemper!

master: a20582c
develop: bfd3994

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@Ocramius Ocramius

Labels
Di enhancement
Projects
None yet
Milestone
2.3.4
Development

Successfully merging this pull request may close these issues.
3 participants
@dkemper @macnibblet @Ocramius