This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Cache: fixed 'Undefined index' error in memory adapter on access tags of... #6878
Closed
marc-mabe
wants to merge
1
commit into
zendframework:master
from
marc-mabe:hotfix/cache_undefined_index
Closed
Cache: fixed 'Undefined index' error in memory adapter on access tags of... #6878
marc-mabe
wants to merge
1
commit into
zendframework:master
from
marc-mabe:hotfix/cache_undefined_index
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -1037,6 +1037,12 @@ public function testTaggable() | |||
$this->markTestSkipped("Storage doesn't implement TaggableInterface"); | |||
} | |||
|
|||
// setTags and getTags on empty memory (no namespace and no key stored) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you abstract this failure case into a different test case please?
… of unregistered namespace
@Ocramius done |
Ocramius
added a commit
that referenced
this pull request
Nov 22, 2014
@marc-mabe merged, thank you! |
gianarb
pushed a commit
to zendframework/zend-cache
that referenced
this pull request
May 15, 2015
… for newly introduced tests
gianarb
pushed a commit
to zendframework/zend-cache
that referenced
this pull request
May 15, 2015
…-undefined-namespaces' Close zendframework/zendframework#6878
gianarb
pushed a commit
to zendframework/zend-cache
that referenced
this pull request
May 15, 2015
…-undefined-namespaces' into develop Close zendframework/zendframework#6878 Forward port zendframework/zendframework#6878
boesing
pushed a commit
to laminas/laminas-cache-storage-adapter-test
that referenced
this pull request
May 24, 2020
…-undefined-namespaces' into develop Close zendframework/zendframework#6878 Forward port zendframework/zendframework#6878
boesing
pushed a commit
to laminas/laminas-cache-storage-adapter-apc
that referenced
this pull request
May 24, 2020
…-undefined-namespaces' into develop Close zendframework/zendframework#6878 Forward port zendframework/zendframework#6878
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... unregistered namespace