Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Zend\Db: Allow adding native predicates to sql queries, respecting nextPredicateCombineOrder #6799

Conversation

Pittiplatsch
Copy link

Fix for #6800

@Ocramius Ocramius self-assigned this Dec 11, 2014
@Ocramius Ocramius modified the milestone: 2.4.0 Dec 11, 2014
@Ocramius Ocramius removed their assignment Dec 16, 2014
@Ocramius
Copy link
Member

@Pittiplatsch what PR/issue is this referencing? The link in the description point at this very page.

@Pittiplatsch
Copy link
Author

Sorry, typo in initial post - fixed issue no.
The discussion I started in #6800 should probably take place here.

@Ocramius Ocramius added this to the 2.4.0 milestone Dec 16, 2014
@Ocramius Ocramius self-assigned this Dec 16, 2014
{
$this->addPredicate(
$predicate,
($this->nextPredicateCombineOperator) ?: $this->defaultCombination
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for the ( and )

@Ocramius Ocramius assigned ralphschindler and unassigned Ocramius Dec 16, 2014
@Ocramius Ocramius removed this from the 2.4.0 milestone Dec 16, 2014
@Ocramius
Copy link
Member

Awaits feedback as per discussion with @Pittiplatsch on IRC.

@Ocramius Ocramius assigned Ocramius and unassigned ralphschindler Jan 15, 2015
@Ocramius Ocramius added this to the 2.4.0 milestone Jan 15, 2015
@Pittiplatsch Pittiplatsch changed the title Test cases for nextPredicateCombineOrder + addPredicate() Zend\Db: Allow adding native predicates to sql queries, respecting nextPredicateCombineOrder Jan 15, 2015
weierophinney added a commit that referenced this pull request Feb 24, 2015
Zend\Db: Allow adding native predicates to sql queries, respecting nextPredicateCombineOrder
weierophinney added a commit that referenced this pull request Feb 24, 2015
@weierophinney
Copy link
Member

Merged to develop for release with 2.4.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants