This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Zend\Db: Allow adding native predicates to sql queries, respecting nextPredicateCombineOrder #6799
Closed
Pittiplatsch
wants to merge
3
commits into
zendframework:master
from
Pittiplatsch:db_predicate_nextcombination
Closed
Zend\Db: Allow adding native predicates to sql queries, respecting nextPredicateCombineOrder #6799
Pittiplatsch
wants to merge
3
commits into
zendframework:master
from
Pittiplatsch:db_predicate_nextcombination
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Pittiplatsch what PR/issue is this referencing? The link in the description point at this very page. |
Sorry, typo in initial post - fixed issue no. |
{ | ||
$this->addPredicate( | ||
$predicate, | ||
($this->nextPredicateCombineOperator) ?: $this->defaultCombination |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for the (
and )
Awaits feedback as per discussion with @Pittiplatsch on IRC. |
Pittiplatsch
changed the title
Test cases for nextPredicateCombineOrder + addPredicate()
Zend\Db: Allow adding native predicates to sql queries, respecting nextPredicateCombineOrder
Jan 15, 2015
weierophinney
added a commit
that referenced
this pull request
Feb 24, 2015
Zend\Db: Allow adding native predicates to sql queries, respecting nextPredicateCombineOrder
weierophinney
added a commit
that referenced
this pull request
Feb 24, 2015
Merged to develop for release with 2.4. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #6800