Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Fixed the unit tests on Windows. The /tmp folder doesn't exist so we sho... #6675

Closed
wants to merge 2 commits into from
Closed

Fixed the unit tests on Windows. The /tmp folder doesn't exist so we sho... #6675

wants to merge 2 commits into from

Conversation

waltertamboer
Copy link
Contributor

These unit tests didn't pass on Windows because the /tmp folder doesn't exist there. We now use the tmp folder as defined by PHP resulting in all unit tests to pass.

…should use the tmp folder as defined by PHP.
@prolic
Copy link
Contributor

prolic commented Sep 19, 2014

👍

@Ocramius Ocramius self-assigned this Nov 22, 2014
@Ocramius Ocramius added this to the 2.4.0 milestone Nov 22, 2014
Ocramius added a commit that referenced this pull request Nov 22, 2014
@Ocramius
Copy link
Member

@waltertamboer thanks! Merged into develop at 955fe7d

@Ocramius Ocramius closed this Nov 22, 2014
@waltertamboer waltertamboer deleted the feature/code-tests-fix-windows branch December 5, 2014 13:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants