This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Allow crossorigin attribute in headScript
#6634
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here the official W3C description: http://www.w3.org/TR/html5/scripting-1.html#attr-script-crossorigin |
| @@ -83,7 +83,7 @@ class HeadScript extends Placeholder\Container\AbstractStandalone | |||
| * | |||
| * @var array | |||
| */ | |||
| protected $optionalAttributes = array('charset', 'defer', 'language', 'src'); | |||
| protected $optionalAttributes = array('charset', 'crossorigin', 'defer', 'language', 'src'); | |||
There was a problem hiding this comment.
Can we also change this to one-per-line for easier diffing in future?
Ocramius
added a commit
that referenced
this pull request
Dec 11, 2014
Ocramius
added a commit
that referenced
this pull request
Dec 11, 2014
Ocramius
added a commit
that referenced
this pull request
Dec 11, 2014
|
Rebased, added tests, merged. Thanks @marek-saji |
gianarb
pushed a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
…ossorigin" attribute is supported Ref: http://www.w3.org/TR/html5/scripting-1.html#attr-script-crossorigin
gianarb
pushed a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
…ly introduced tests
gianarb
pushed a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
…in-headscript-attribute' Close zendframework/zendframework#6634
gianarb
pushed a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
…in-headscript-attribute' into develop Close zendframework/zendframework#6634 Forward port zendframework/zendframework#6634
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script#attr-crossorigin