This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
fixes #6435: Race Condition in filesystem cache on prepare dir structure #6573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump to 2.3.3dev
|
@marc-mabe I'm fairly sure that you know more about the locking issues on the FS than me. What I'm worrying about is that we'd lose some valuable integration testing when dealing with exotic OSs like windows. |
|
@Ocramius That's a good point! But we don't need to mock the fs everywhere in the tests - only when it's needed to do a good testing job. In the case of the timing testing issue it could be possible to mock the timing functions instead of the fs itself. |
|
@Ocramius can this PR be merged even without a test? |
|
@marc-mabe testing this would be way too tricky without completely mocking out the FS. I think it's fine as-is. |
|
Merged, thanks @marc-mabe! |
gianarb
pushed a commit
to zendframework/zend-cache
that referenced
this pull request
May 15, 2015
…system-race-conditions-fixes-for-zendframework/zf2#6435' Close zendframework/zendframework#6573 Close zendframework/zendframework#6435
gianarb
pushed a commit
to zendframework/zend-cache
that referenced
this pull request
May 15, 2015
…system-race-conditions-fixes-for-zendframework/zf2#6435' into develop Close zendframework/zendframework#6573 Close zendframework/zendframework#6435 Forward port zendframework/zendframework#6573 Forward port zendframework/zendframework#6435
boesing
pushed a commit
to laminas/laminas-cache-storage-adapter-apc
that referenced
this pull request
May 24, 2020
…system-race-conditions-fixes-for-zendframework/zf2#6435' into develop Close zendframework/zendframework#6573 Close zendframework/zendframework#6435 Forward port zendframework/zendframework#6573 Forward port zendframework/zendframework#6435
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the issue #6435
(unit testable only with mocking/wrapping filesystem)
@Ocramius we should have a discussion about fs mocking ;)